Make new StreamController be async by default.

sdk/lib/io/websocket_impl.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.io;
 
 const String _webSocketGUID = "258EAFA5-E914-47DA-95CA-C5AB0DC85B11";
 
 class _WebSocketMessageType {
   static const int NONE = 0;
@@ skipping 75 matching lines @@
               if (_currentMessageType == _WebSocketMessageType.NONE) {
                 throw new WebSocketException("Protocol error");
               }
               break;
 
             case _WebSocketOpcode.TEXT:
               if (_currentMessageType != _WebSocketMessageType.NONE) {
                 throw new WebSocketException("Protocol error");
               }
               _currentMessageType = _WebSocketMessageType.TEXT;
-              _controller = new StreamController();
+              _controller = new StreamController(sync: true);
               _controller.stream
                   .transform(new Utf8DecoderTransformer(null))
                   .fold(new StringBuffer(), (buffer, str) => buffer..write(str))
                   .then((buffer) {
                     sink.add(buffer.toString());
                   }, onError: (error) {
                     sink.addError(error);
                   });
               break;
 
             case _WebSocketOpcode.BINARY:
               if (_currentMessageType != _WebSocketMessageType.NONE) {
                 throw new WebSocketException("Protocol error");
               }
               _currentMessageType = _WebSocketMessageType.BINARY;
-              _controller = new StreamController();
+              _controller = new StreamController(sync: true);
               _controller.stream
                   .fold(new _BufferList(), (buffer, data) => buffer..add(data))
                   .then((buffer) {
                     sink.add(buffer.readBytes());
                   }, onError: (error) {
                     sink.addError(error);
                   });
               break;
 
             case _WebSocketOpcode.CLOSE:
@@ skipping 246 matching lines @@
 
 
 class _WebSocketPong {
   final List<int> payload;
   _WebSocketPong([this.payload = null]);
 }
 
 
 class _WebSocketTransformerImpl implements WebSocketTransformer {
   final StreamController<WebSocket> _controller =
-      new StreamController<WebSocket>();
+      new StreamController<WebSocket>(sync: true);
 
   Stream<WebSocket> bind(Stream<HttpRequest> stream) {
     stream.listen((request) {
         _upgrade(request)
             .then((WebSocket webSocket) => _controller.add(webSocket))
             .catchError((error) => _controller.addError(error));
     });
 
     return _controller.stream;
   }
@@ skipping 169 matching lines @@
   _WebSocketConsumer(_WebSocketImpl this.webSocket, Socket this.socket);
 
   void _onListen() {
     if (_subscription != null) {
       _subscription.cancel();
     }
   }
 
   _ensureController() {
     if (_controller != null) return;
-    _controller = new StreamController(onPause: () => _subscription.pause(),
+    _controller = new StreamController(sync: true,onPause: () => _subscription.pause(),

[floitsch, 2013/05/30 12:13:48]

new line missing.

[Lasse Reichstein Nielsen, 2013/05/31 05:51:59]

Done.

                                        onResume: () => _subscription.resume(),
                                        onCancel: _onListen);
     var stream = _controller.stream.transform(
         new _WebSocketOutgoingTransformer(webSocket));
     socket.addStream(stream)
         .then((_) {
                 _done();
                 _closeCompleter.complete(webSocket);
               },
               onError: (error) {
@@ skipping 41 matching lines @@
   }
 
   void add(data) {
     _ensureController();
     _controller.add(data);
   }
 }
 
 
 class _WebSocketImpl extends Stream implements WebSocket {
-  final StreamController _controller = new StreamController();
+  final StreamController _controller = new StreamController(sync: true);
   StreamSink _sink;
 
   final Socket _socket;
   final bool _serverSide;
   int _readyState = WebSocket.CONNECTING;
   bool _writeClosed = false;
   int _closeCode;
   String _closeReason;
 
   int _outCloseCode;
@@ skipping 153 matching lines @@
            (code < WebSocketStatus.NORMAL_CLOSURE ||
             code == WebSocketStatus.RESERVED_1004 ||
             code == WebSocketStatus.NO_STATUS_RECEIVED ||
             code == WebSocketStatus.ABNORMAL_CLOSURE ||
             (code > WebSocketStatus.INTERNAL_SERVER_ERROR &&
              code < WebSocketStatus.RESERVED_1015) ||
             (code >= WebSocketStatus.RESERVED_1015 &&
              code < 3000));
   }
 }