pkg/logging/lib/logging.dart - Issue 16125005: Make new StreamController be async by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/logging/lib/logging.dart

Issue 16125005: Make new StreamController be async by default. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review comments Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/logging/lib/logging.dart

diff --git a/pkg/logging/lib/logging.dart b/pkg/logging/lib/logging.dart

index 94bf5f3dfdc3d51412980b4561a347f552097a02..b29f076cb0a225c604c2fd61f32bca07b61c9d5b 100644

--- a/pkg/logging/lib/logging.dart

+++ b/pkg/logging/lib/logging.dart

@@ -196,7 +196,7 @@ class Logger {

Stream<LogRecord> _getStream() {

if (hierarchicalLoggingEnabled || parent == null) {

if (_controller == null) {

- _controller = new StreamController<LogRecord>();

+ _controller = new StreamController<LogRecord>(sync: true);

_stream = _controller.stream.asBroadcastStream();

}

return _stream;

« no previous file with comments | « pkg/http/test/response_test.dart ('k') | pkg/scheduled_test/lib/src/mock_clock.dart » ('j') | no next file with comments »