Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: sdk/lib/mdv_observe_impl/mdv_observe_impl.dart

Issue 16125005: Make new StreamController be async by default. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sdk/lib/isolate/isolate_stream.dart ('k') | sdk/lib/web_audio/dart2js/web_audio_dart2js.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 // This library itself is undocumented and not supported for end use. 5 // This library itself is undocumented and not supported for end use.
6 // Because dart:html must use some of this functionality, it has to be available 6 // Because dart:html must use some of this functionality, it has to be available
7 // via a dart:* library. The public APIs are reexported via package:mdv_observe. 7 // via a dart:* library. The public APIs are reexported via package:mdv_observe.
8 // Generally we try to keep this library minimal, with utility types and 8 // Generally we try to keep this library minimal, with utility types and
9 // functions in the package. 9 // functions in the package.
10 library dart.mdv_observe_impl; 10 library dart.mdv_observe_impl;
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 */ 56 */
57 typedef ObservableBase = Object with ObservableMixin; 57 typedef ObservableBase = Object with ObservableMixin;
58 58
59 /** 59 /**
60 * Mixin for implementing [Observable] objects. 60 * Mixin for implementing [Observable] objects.
61 * 61 *
62 * When a field, property, or indexable item is changed, a derived class should 62 * When a field, property, or indexable item is changed, a derived class should
63 * call [notifyPropertyChange]. See that method for an example. 63 * call [notifyPropertyChange]. See that method for an example.
64 */ 64 */
65 abstract class ObservableMixin implements Observable { 65 abstract class ObservableMixin implements Observable {
66 StreamController _multiplexController; 66 StreamController _broadcastController;
67 List<ChangeRecord> _changes; 67 List<ChangeRecord> _changes;
68 68
69 Stream<List<ChangeRecord>> get changes { 69 Stream<List<ChangeRecord>> get changes {
70 if (_multiplexController == null) { 70 if (_broadcastController == null) {
71 _multiplexController = 71 _broadcastController =
72 new StreamController<List<ChangeRecord>>.broadcast(); 72 new StreamController<List<ChangeRecord>>.broadcast(sync: true);
73 } 73 }
74 return _multiplexController.stream; 74 return _broadcastController.stream;
75 } 75 }
76 76
77 void _deliverChanges() { 77 void _deliverChanges() {
78 var changes = _changes; 78 var changes = _changes;
79 _changes = null; 79 _changes = null;
80 if (hasObservers && changes != null) { 80 if (hasObservers && changes != null) {
81 // TODO(jmesserly): make "changes" immutable 81 // TODO(jmesserly): make "changes" immutable
82 _multiplexController.add(changes); 82 _broadcastController.add(changes);
83 } 83 }
84 } 84 }
85 85
86 /** 86 /**
87 * True if this object has any observers, and should call 87 * True if this object has any observers, and should call
88 * [notifyPropertyChange] for changes. 88 * [notifyPropertyChange] for changes.
89 */ 89 */
90 bool get hasObservers => _multiplexController != null && 90 bool get hasObservers => _broadcastController != null &&
91 _multiplexController.hasListener; 91 _broadcastController.hasListener;
92 92
93 /** 93 /**
94 * Notify that the field [name] of this object has been changed. 94 * Notify that the field [name] of this object has been changed.
95 * 95 *
96 * The [oldValue] and [newValue] are also recorded. If the two values are 96 * The [oldValue] and [newValue] are also recorded. If the two values are
97 * identical, no change will be recorded. 97 * identical, no change will be recorded.
98 * 98 *
99 * For convenience this returns [newValue]. This makes it easy to use in a 99 * For convenience this returns [newValue]. This makes it easy to use in a
100 * setter: 100 * setter:
101 * 101 *
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 /** Queues an action to happen during the [deliverChangeRecords] timeslice. */ 217 /** Queues an action to happen during the [deliverChangeRecords] timeslice. */
218 void queueChangeRecords(void deliverChanges()) { 218 void queueChangeRecords(void deliverChanges()) {
219 if (_deliverCallbacks == null) { 219 if (_deliverCallbacks == null) {
220 _deliverCallbacks = new Queue<Function>(); 220 _deliverCallbacks = new Queue<Function>();
221 runAsync(deliverChangeRecords); 221 runAsync(deliverChangeRecords);
222 } 222 }
223 _deliverCallbacks.add(deliverChanges); 223 _deliverCallbacks.add(deliverChanges);
224 } 224 }
225 225
226 Queue _deliverCallbacks; 226 Queue _deliverCallbacks;
OLDNEW
« no previous file with comments | « sdk/lib/isolate/isolate_stream.dart ('k') | sdk/lib/web_audio/dart2js/web_audio_dart2js.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698