Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1318)

Unified Diff: sdk/lib/_internal/pub/test/error_group_test.dart

Issue 16125005: Make new StreamController be async by default. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review comments Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/utils.dart ('k') | sdk/lib/async/stream.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/test/error_group_test.dart
diff --git a/sdk/lib/_internal/pub/test/error_group_test.dart b/sdk/lib/_internal/pub/test/error_group_test.dart
index d22f12cf63ee7421178f2a6893610bdea7d8db79..7cad9be8904f65bd223608688671e25bb1a522a7 100644
--- a/sdk/lib/_internal/pub/test/error_group_test.dart
+++ b/sdk/lib/_internal/pub/test/error_group_test.dart
@@ -38,7 +38,8 @@ main() {
expect(() => errorGroup.registerFuture(new Future.value()),
throwsStateError);
- expect(() => errorGroup.registerStream(new StreamController().stream),
+ expect(() => errorGroup.registerStream(
+ new StreamController(sync: true).stream),
throwsStateError);
});
});
@@ -66,7 +67,8 @@ main() {
completer.future.then(expectAsync1((_) {
expect(() => errorGroup.registerFuture(new Future.value()),
throwsStateError);
- expect(() => errorGroup.registerStream(new StreamController().stream),
+ expect(() => errorGroup.registerStream(
+ new StreamController(sync: true).stream),
throwsStateError);
}));
});
@@ -205,7 +207,7 @@ main() {
setUp(() {
errorGroup = new ErrorGroup();
- controller = new StreamController();
+ controller = new StreamController(sync: true);
stream = errorGroup.registerStream(controller.stream.asBroadcastStream());
});
@@ -277,7 +279,7 @@ main() {
setUp(() {
errorGroup = new ErrorGroup();
- controller = new StreamController();
+ controller = new StreamController(sync: true);
stream = errorGroup.registerStream(controller.stream);
});
@@ -326,8 +328,8 @@ main() {
setUp(() {
errorGroup = new ErrorGroup();
- controller1 = new StreamController();
- controller2 = new StreamController();
+ controller1 = new StreamController(sync: true);
+ controller2 = new StreamController(sync: true);
stream1 = errorGroup.registerStream(controller1.stream.asBroadcastStream());
stream2 = errorGroup.registerStream(controller2.stream.asBroadcastStream());
});
@@ -385,7 +387,7 @@ main() {
setUp(() {
errorGroup = new ErrorGroup();
- controller = new StreamController();
+ controller = new StreamController(sync: true);
stream = errorGroup.registerStream(controller.stream.asBroadcastStream());
completer = new Completer();
future = errorGroup.registerFuture(completer.future);
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/utils.dart ('k') | sdk/lib/async/stream.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698