Change the signature for all network bind calls.

Change the signature for all network bind calls.

All the bind calls on RawServerSocket, ServerSocket,
RawSecureServerSocket, SecureServerSocket and HttpServer (and
bindSecure on HttpServer) now have mandatory address and port
parameters. All the rest of the parameters are named optional
(including backlog).

The address parameter can be an InternetAddress or a String for all
these calls.

R=ajohnsen@google.com, whesse@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=22227

[Anders Johnsen, 2013-05-01 07:50:19]

LGTM

https://codereview.chromium.org/14640008/diff/1/runtime/bin/socket_patch.dart
File runtime/bin/socket_patch.dart (right):

https://codereview.chromium.org/14640008/diff/1/runtime/bin/socket_patch.dart...
runtime/bin/socket_patch.dart:9: if (address == null) address =
InternetAddress.LOOPBACK_IP_V4;
No 'null' check - should not be null.

https://codereview.chromium.org/14640008/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/14640008/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:1637: static Future<HttpServer> bind(host, int port,
int backlog) {
host -> address

https://codereview.chromium.org/14640008/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:1643: static Future<HttpServer> bindSecure(host,
Ditto.

https://codereview.chromium.org/14640008/diff/1/sdk/lib/io/secure_server_sock...
File sdk/lib/io/secure_server_socket.dart (right):

https://codereview.chromium.org/14640008/diff/1/sdk/lib/io/secure_server_sock...
sdk/lib/io/secure_server_socket.dart:29: * [InternetAddress.LOOPBACK_IP_V6]. To
allow for incoming
Will LOOPBACK_IP_V6 and ANY_IP_V6 allow IPv4 as well?

[Søren Gjesse, 2013-05-01 07:55:20]

https://codereview.chromium.org/14640008/diff/1/runtime/bin/socket_patch.dart
File runtime/bin/socket_patch.dart (right):

https://codereview.chromium.org/14640008/diff/1/runtime/bin/socket_patch.dart...
runtime/bin/socket_patch.dart:9: if (address == null) address =
InternetAddress.LOOPBACK_IP_V4;
On 2013/05/01 07:50:19, Anders Johnsen wrote:
> No 'null' check - should not be null.

Done.

https://codereview.chromium.org/14640008/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/14640008/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:1637: static Future<HttpServer> bind(host, int port,
int backlog) {
On 2013/05/01 07:50:19, Anders Johnsen wrote:
> host -> address

Done.

https://codereview.chromium.org/14640008/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:1643: static Future<HttpServer> bindSecure(host,
On 2013/05/01 07:50:19, Anders Johnsen wrote:
> Ditto.

Done.

https://codereview.chromium.org/14640008/diff/1/sdk/lib/io/secure_server_sock...
File sdk/lib/io/secure_server_socket.dart (right):

https://codereview.chromium.org/14640008/diff/1/sdk/lib/io/secure_server_sock...
sdk/lib/io/secure_server_socket.dart:29: * [InternetAddress.LOOPBACK_IP_V6]. To
allow for incoming
On 2013/05/01 07:50:19, Anders Johnsen wrote:
> Will LOOPBACK_IP_V6 and ANY_IP_V6 allow IPv4 as well?

We have to decide on what the default should be and then update the comment. See
previous message on this CL.

[Søren Gjesse, 2013-05-01 08:22:10]

Updated comments with IPv6 info.

[Anders Johnsen, 2013-05-01 08:46:12]

LGTM, thanks Soeren!

[Bill Hesse, 2013-05-01 08:57:06]

LGTM.

https://codereview.chromium.org/14640008/diff/7001/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/14640008/diff/7001/sdk/lib/io/http.dart#newco...
sdk/lib/io/http.dart:731: * HTTP response to be send back to the client.
An [HttpResponse] represents the headers and data to be returned to a client in
response to an HTTP request.

https://codereview.chromium.org/14640008/diff/7001/sdk/lib/io/socket.dart
File sdk/lib/io/socket.dart (right):

https://codereview.chromium.org/14640008/diff/7001/sdk/lib/io/socket.dart#new...
sdk/lib/io/socket.dart:102: /**
A [RawServerSocket] represents a listening socket, and provides a stream of
low-level [RawSocket] objects, one for each connection made to the listening
socket.

https://codereview.chromium.org/14640008/diff/7001/sdk/lib/io/socket.dart#new...
sdk/lib/io/socket.dart:156: * The [ServerSocket] is server socket, providing a
stream of high-level
A [ServerSocket] represents a listening socket, and provides a stream of
[Socket] objects, one for each connection made to the listening socket.

https://codereview.chromium.org/14640008/diff/7001/tests/standalone/io/http_1...
File tests/standalone/io/http_10_test.dart (right):

https://codereview.chromium.org/14640008/diff/7001/tests/standalone/io/http_1...
tests/standalone/io/http_10_test.dart:19: HttpServer.bind("127.0.0.1",
0).then((server) {
It is a pain, but shouldn't we be using IP4 LOOPBACK InternetAddress here?

https://codereview.chromium.org/14640008/diff/7001/tests/standalone/io/http_c...
File tests/standalone/io/http_compression_test.dart (right):

https://codereview.chromium.org/14640008/diff/7001/tests/standalone/io/http_c...
tests/standalone/io/http_compression_test.dart:16: HttpServer.bind("127.0.0.1",
0).then((server) {
I guess it wouldn't be worth it to change all of these - they are fine as is.

https://codereview.chromium.org/14640008/diff/7001/tests/standalone/io/raw_se...
File tests/standalone/io/raw_secure_server_socket_test.dart (right):

https://codereview.chromium.org/14640008/diff/7001/tests/standalone/io/raw_se...
tests/standalone/io/raw_secure_server_socket_test.dart:434:
RawServerSocket.bind(HOST_NAME, 0, backlog: 5).then(serverReady);
I think the default should be used here, if it is used everywhere else.

https://codereview.chromium.org/14640008/diff/7001/tests/standalone/io/socket...
File tests/standalone/io/socket_invalid_arguments_test.dart (right):

https://codereview.chromium.org/14640008/diff/7001/tests/standalone/io/socket...
tests/standalone/io/socket_invalid_arguments_test.dart:28:
ServerSocket.bind("127.0.0.1", 0, backlog: 5).then((server) {
This is dropped everywhere else, why not here?

https://codereview.chromium.org/14640008/diff/7001/tests/standalone/io/socket...
File tests/standalone/io/socket_upgrade_to_secure_test.dart (right):

https://codereview.chromium.org/14640008/diff/7001/tests/standalone/io/socket...
tests/standalone/io/socket_upgrade_to_secure_test.dart:212:
ServerSocket.bind(HOST_NAME, 0, backlog: 5).then(serverReady);
Drop 5?

[Søren Gjesse, 2013-05-01 09:06:42]

https://codereview.chromium.org/14640008/diff/7001/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/14640008/diff/7001/sdk/lib/io/http.dart#newco...
sdk/lib/io/http.dart:731: * HTTP response to be send back to the client.
On 2013/05/01 08:57:06, Bill Hesse wrote:
> An [HttpResponse] represents the headers and data to be returned to a client
in
> response to an HTTP request.

Done.

https://codereview.chromium.org/14640008/diff/7001/sdk/lib/io/socket.dart
File sdk/lib/io/socket.dart (right):

https://codereview.chromium.org/14640008/diff/7001/sdk/lib/io/socket.dart#new...
sdk/lib/io/socket.dart:102: /**
On 2013/05/01 08:57:06, Bill Hesse wrote:
> A [RawServerSocket] represents a listening socket, and provides a stream of
> low-level [RawSocket] objects, one for each connection made to the listening
> socket.

Done.

https://codereview.chromium.org/14640008/diff/7001/sdk/lib/io/socket.dart#new...
sdk/lib/io/socket.dart:156: * The [ServerSocket] is server socket, providing a
stream of high-level
On 2013/05/01 08:57:06, Bill Hesse wrote:
> A [ServerSocket] represents a listening socket, and provides a stream of
> [Socket] objects, one for each connection made to the listening socket.

Done.

https://codereview.chromium.org/14640008/diff/7001/tests/standalone/io/http_1...
File tests/standalone/io/http_10_test.dart (right):

https://codereview.chromium.org/14640008/diff/7001/tests/standalone/io/http_1...
tests/standalone/io/http_10_test.dart:19: HttpServer.bind("127.0.0.1",
0).then((server) {
On 2013/05/01 08:57:06, Bill Hesse wrote:
> It is a pain, but shouldn't we be using IP4 LOOPBACK InternetAddress here?

I have used InternetAddress.LOOPBACK_IP_V4 in some tests. It should be just as
fine to use "127.0.0.1" as it is exactly the same address.

https://codereview.chromium.org/14640008/diff/7001/tests/standalone/io/http_c...
File tests/standalone/io/http_compression_test.dart (right):

https://codereview.chromium.org/14640008/diff/7001/tests/standalone/io/http_c...
tests/standalone/io/http_compression_test.dart:16: HttpServer.bind("127.0.0.1",
0).then((server) {
On 2013/05/01 08:57:06, Bill Hesse wrote:
> I guess it wouldn't be worth it to change all of these - they are fine as is.

Yes.

https://codereview.chromium.org/14640008/diff/7001/tests/standalone/io/raw_se...
File tests/standalone/io/raw_secure_server_socket_test.dart (right):

https://codereview.chromium.org/14640008/diff/7001/tests/standalone/io/raw_se...
tests/standalone/io/raw_secure_server_socket_test.dart:434:
RawServerSocket.bind(HOST_NAME, 0, backlog: 5).then(serverReady);
On 2013/05/01 08:57:06, Bill Hesse wrote:
> I think the default should be used here, if it is used everywhere else.

Done.

https://codereview.chromium.org/14640008/diff/7001/tests/standalone/io/socket...
File tests/standalone/io/socket_invalid_arguments_test.dart (right):

https://codereview.chromium.org/14640008/diff/7001/tests/standalone/io/socket...
tests/standalone/io/socket_invalid_arguments_test.dart:28:
ServerSocket.bind("127.0.0.1", 0, backlog: 5).then((server) {
On 2013/05/01 08:57:06, Bill Hesse wrote:
> This is dropped everywhere else, why not here?

No particular reason, removed.

https://codereview.chromium.org/14640008/diff/7001/tests/standalone/io/socket...
File tests/standalone/io/socket_upgrade_to_secure_test.dart (right):

https://codereview.chromium.org/14640008/diff/7001/tests/standalone/io/socket...
tests/standalone/io/socket_upgrade_to_secure_test.dart:212:
ServerSocket.bind(HOST_NAME, 0, backlog: 5).then(serverReady);
On 2013/05/01 08:57:06, Bill Hesse wrote:
> Drop 5?

Done.

[Søren Gjesse, 2013-05-01 09:14:35]

Committed patchset #4 manually as r22227 (presubmit successful).