Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: tests/standalone/io/http_10_test.dart

Issue 14640008: Change the signature for all network bind calls. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments by whesse@ Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/socket.dart ('k') | tests/standalone/io/http_advanced_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/http_10_test.dart
diff --git a/tests/standalone/io/http_10_test.dart b/tests/standalone/io/http_10_test.dart
index 9250a367262fb743196c87dbde4c0df7d482b8c0..d3ade02c7de8f6d2363d8d899e5ccaf28b87737c 100644
--- a/tests/standalone/io/http_10_test.dart
+++ b/tests/standalone/io/http_10_test.dart
@@ -16,7 +16,7 @@ import "dart:io";
// server sets a content length but still needs to close the
// connection as there is no keep alive.
void testHttp10NoKeepAlive() {
- HttpServer.bind().then((server) {
+ HttpServer.bind("127.0.0.1", 0).then((server) {
server.listen(
(HttpRequest request) {
Expect.isNull(request.headers.value('content-length'));
@@ -71,7 +71,7 @@ void testHttp10NoKeepAlive() {
// content length so it has to close the connection to mark the end of
// the response.
void testHttp10ServerClose() {
- HttpServer.bind().then((server) {
+ HttpServer.bind("127.0.0.1", 0).then((server) {
server.listen(
(HttpRequest request) {
Expect.isNull(request.headers.value('content-length'));
@@ -124,7 +124,7 @@ void testHttp10ServerClose() {
// server sets a content length so the persistent connection can be
// used.
void testHttp10KeepAlive() {
- HttpServer.bind().then((server) {
+ HttpServer.bind("127.0.0.1", 0).then((server) {
server.listen(
(HttpRequest request) {
Expect.isNull(request.headers.value('content-length'));
@@ -180,7 +180,7 @@ void testHttp10KeepAlive() {
// server does not set a content length so it cannot honor connection
// keep alive.
void testHttp10KeepAliveServerCloses() {
- HttpServer.bind().then((server) {
+ HttpServer.bind("127.0.0.1", 0).then((server) {
server.listen(
(HttpRequest request) {
Expect.isNull(request.headers.value('content-length'));
« no previous file with comments | « sdk/lib/io/socket.dart ('k') | tests/standalone/io/http_advanced_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698