Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: tests/standalone/io/socket_ipv6_test.dart

Issue 14640008: Change the signature for all network bind calls. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments by whesse@ Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/socket_invalid_arguments_test.dart ('k') | tests/standalone/io/socket_port_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/socket_ipv6_test.dart
diff --git a/tests/standalone/io/socket_ipv6_test.dart b/tests/standalone/io/socket_ipv6_test.dart
index 032bd9c08a17a7d9f98bc86b10dffdf990b32d02..80d9e7da092398e3c9cf0d87a3ca81f1f9e1f9fa 100644
--- a/tests/standalone/io/socket_ipv6_test.dart
+++ b/tests/standalone/io/socket_ipv6_test.dart
@@ -10,7 +10,7 @@ const ANY = InternetAddressType.ANY;
void testIPv6toIPv6() {
InternetAddress.lookup("::0", type: ANY).then((serverAddr) {
InternetAddress.lookup("::1", type: ANY).then((clientAddr) {
- ServerSocket.bind(serverAddr.first).then((server) {
+ ServerSocket.bind(serverAddr.first, 0).then((server) {
server.listen((socket) {
socket.destroy();
server.close();
@@ -25,7 +25,7 @@ void testIPv6toIPv6() {
void testIPv4toIPv6() {
InternetAddress.lookup("::0", type: ANY).then((serverAddr) {
- ServerSocket.bind(serverAddr.first).then((server) {
+ ServerSocket.bind(serverAddr.first, 0).then((server) {
server.listen((socket) {
socket.destroy();
server.close();
@@ -39,7 +39,7 @@ void testIPv4toIPv6() {
void testIPv6toIPv4() {
InternetAddress.lookup("::1", type: ANY).then((clientAddr) {
- ServerSocket.bind("127.0.0.1").then((server) {
+ ServerSocket.bind("127.0.0.1", 0).then((server) {
server.listen((socket) {
throw "Unexpected socket";
});
@@ -51,7 +51,7 @@ void testIPv6toIPv4() {
}
void testIPv4toIPv4() {
- ServerSocket.bind("127.0.0.1").then((server) {
+ ServerSocket.bind("127.0.0.1", 0).then((server) {
server.listen((socket) {
socket.destroy();
server.close();
« no previous file with comments | « tests/standalone/io/socket_invalid_arguments_test.dart ('k') | tests/standalone/io/socket_port_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698