Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Unified Diff: tests/standalone/io/http_shutdown_test.dart

Issue 14640008: Change the signature for all network bind calls. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments by whesse@ Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/http_session_test.dart ('k') | tests/standalone/io/raw_secure_server_closing_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/http_shutdown_test.dart
diff --git a/tests/standalone/io/http_shutdown_test.dart b/tests/standalone/io/http_shutdown_test.dart
index 1cf48032f6c2450299852b789b8a7187ae1afee7..f6b1424b8a39b398b6087b2a5524784dc036cc95 100644
--- a/tests/standalone/io/http_shutdown_test.dart
+++ b/tests/standalone/io/http_shutdown_test.dart
@@ -13,7 +13,7 @@ import "dart:io";
void test1(int totalConnections) {
// Server which just closes immediately.
- HttpServer.bind().then((server) {
+ HttpServer.bind("127.0.0.1", 0).then((server) {
server.listen((HttpRequest request) {
request.response.close();
});
@@ -39,7 +39,7 @@ void test1(int totalConnections) {
void test2(int totalConnections, int outputStreamWrites) {
// Server which responds without waiting for request body.
- HttpServer.bind().then((server) {
+ HttpServer.bind("127.0.0.1", 0).then((server) {
server.listen((HttpRequest request) {
request.response.write("!dlrow ,olleH");
request.response.close();
@@ -83,7 +83,7 @@ void test2(int totalConnections, int outputStreamWrites) {
void test3(int totalConnections) {
// Server which responds when request body has been received.
- HttpServer.bind().then((server) {
+ HttpServer.bind("127.0.0.1", 0).then((server) {
server.listen((HttpRequest request) {
request.listen((_) {}, onDone: () {
@@ -117,7 +117,7 @@ void test3(int totalConnections) {
void test4() {
- HttpServer.bind().then((server) {
+ HttpServer.bind("127.0.0.1", 0).then((server) {
server.listen((var request) {
request.listen((_) {}, onDone: () {
@@ -145,7 +145,7 @@ void test4() {
void test5(int totalConnections) {
- HttpServer.bind().then((server) {
+ HttpServer.bind("127.0.0.1", 0).then((server) {
server.listen(
(request) {
request.listen(
« no previous file with comments | « tests/standalone/io/http_session_test.dart ('k') | tests/standalone/io/raw_secure_server_closing_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698