tests/standalone/io/http_proxy_test.dart - Issue 14640008: Change the signature for all network bind calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/standalone/io/http_proxy_test.dart

Issue 14640008: Change the signature for all network bind calls. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments by whesse@ Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/standalone/io/http_proxy_test.dart

diff --git a/tests/standalone/io/http_proxy_test.dart b/tests/standalone/io/http_proxy_test.dart

index 365ce2960d43fc237e0fc85b86a46e19279e58db..197b11a3dbd410969e8b8aea1968e39b748f5ef8 100644

--- a/tests/standalone/io/http_proxy_test.dart

+++ b/tests/standalone/io/http_proxy_test.dart

@@ -23,7 +23,7 @@ class Server {

Future f = secure

? HttpServer.bindSecure(

"localhost", 0, certificateName: 'localhost_cert')

- : HttpServer.bind("localhost");

+ : HttpServer.bind("localhost", 0);

return f.then((s) {

server = s;

x.complete(this);

@@ -97,7 +97,7 @@ class ProxyServer {

Future<ProxyServer> start() {

var x = new Completer();

- HttpServer.bind("localhost").then((s) {

+ HttpServer.bind("localhost", 0).then((s) {

server = s;

x.complete(this);

server.listen((HttpRequest request) {