Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: tests/standalone/io/raw_secure_server_closing_test.dart

Issue 14640008: Change the signature for all network bind calls. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments by whesse@ Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/http_shutdown_test.dart ('k') | tests/standalone/io/raw_secure_server_socket_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/raw_secure_server_closing_test.dart
diff --git a/tests/standalone/io/raw_secure_server_closing_test.dart b/tests/standalone/io/raw_secure_server_closing_test.dart
index 11e641b557c4470311a4cfee9b318d5aa052b858..c1b7ddc724e48022c4acea118cdbf4cddac72de0 100644
--- a/tests/standalone/io/raw_secure_server_closing_test.dart
+++ b/tests/standalone/io/raw_secure_server_closing_test.dart
@@ -24,7 +24,7 @@ void testCloseOneEnd(String toClose) {
.then((_) {
port.close();
});
- RawSecureServerSocket.bind(HOST_NAME, 0, 5, CERTIFICATE).then((server) {
+ RawSecureServerSocket.bind(HOST_NAME, 0, CERTIFICATE).then((server) {
server.listen((serverConnection) {
serverConnection.listen((event) {
if (toClose == "server" || event == RawSocketEvent.READ_CLOSED) {
@@ -54,7 +54,7 @@ void testCloseOneEnd(String toClose) {
void testCloseBothEnds() {
ReceivePort port = new ReceivePort();
- RawSecureServerSocket.bind(HOST_NAME, 0, 5, CERTIFICATE).then((server) {
+ RawSecureServerSocket.bind(HOST_NAME, 0, CERTIFICATE).then((server) {
var clientEndFuture = RawSecureSocket.connect(HOST_NAME, server.port);
server.listen((serverEnd) {
clientEndFuture.then((clientEnd) {
@@ -76,8 +76,8 @@ testPauseServerSocket() {
RawSecureServerSocket.bind(HOST_NAME,
0,
- 2 * socketCount,
- CERTIFICATE).then((server) {
+ CERTIFICATE,
+ backlog: 2 * socketCount).then((server) {
Expect.isTrue(server.port > 0);
var subscription;
subscription = server.listen((connection) {
@@ -116,7 +116,7 @@ testCloseServer() {
ReceivePort port = new ReceivePort();
List ends = [];
- RawSecureServerSocket.bind(HOST_NAME, 0, 15, CERTIFICATE).then((server) {
+ RawSecureServerSocket.bind(HOST_NAME, 0, CERTIFICATE).then((server) {
Expect.isTrue(server.port > 0);
void checkDone() {
if (ends.length < 2 * socketCount) return;
« no previous file with comments | « tests/standalone/io/http_shutdown_test.dart ('k') | tests/standalone/io/raw_secure_server_socket_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698