Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 12401002: Make List.from and Iterable.toList default to not growable. (Closed)

Created:
7 years, 9 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 9 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make List.from and Iterable.toList default to not growable. Committed: https://code.google.com/p/dart/source/detail?r=19391

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -165 lines) Patch
M pkg/args/lib/args.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/args/lib/src/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/args/lib/src/usage.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/pathos/lib/path.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/scheduled_test/lib/src/schedule.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/serialization/lib/src/serialization_helpers.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/lib/array.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/lib/byte_array.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/expando_patch.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/lib/growable_array.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/third_party/dromaeo/Suites.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_collection_dev/iterable.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_array.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/bailout.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/util/link.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/util/link_implementation.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/queue.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/iterable.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/list.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 38 chunks +38 lines, -38 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 39 chunks +43 lines, -38 lines 0 comments Download
M sdk/lib/html/html_common/filtered_element_list.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/web_sql/dart2js/web_sql_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +0 lines, -24 lines 0 comments Download
M tests/corelib/collection_removes_test.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M tests/corelib/list_growable_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/src/CssClassSet.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/WrappedList.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/immutable_list_mixin.darttemplate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
7 years, 9 months ago (2013-03-04 14:39:09 UTC) #1
floitsch
LGTM.
7 years, 9 months ago (2013-03-04 14:42:32 UTC) #2
Lasse Reichstein Nielsen
7 years, 9 months ago (2013-03-04 14:56:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19391 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698