Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: sdk/lib/svg/dart2js/svg_dart2js.dart

Issue 12401002: Make List.from and Iterable.toList default to not growable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/html/html_common/filtered_element_list.dart ('k') | sdk/lib/svg/dartium/svg_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/svg/dart2js/svg_dart2js.dart
diff --git a/sdk/lib/svg/dart2js/svg_dart2js.dart b/sdk/lib/svg/dart2js/svg_dart2js.dart
index 771ebde3793b7628c448f2875ecb698561fc98da..0784b5a151f8f0a14dcef8b9809ccc611e94b3c4 100644
--- a/sdk/lib/svg/dart2js/svg_dart2js.dart
+++ b/sdk/lib/svg/dart2js/svg_dart2js.dart
@@ -3093,7 +3093,7 @@ class LengthList implements JavaScriptIndexingBehavior, List<Length> native "*SV
bool any(bool f(Length element)) => IterableMixinWorkaround.any(this, f);
- List<Length> toList({ bool growable: false }) =>
+ List<Length> toList({ bool growable: true }) =>
new List<Length>.from(this, growable: growable);
Set<Length> toSet() => new Set<Length>.from(this);
@@ -3719,7 +3719,7 @@ class NumberList implements JavaScriptIndexingBehavior, List<Number> native "*SV
bool any(bool f(Number element)) => IterableMixinWorkaround.any(this, f);
- List<Number> toList({ bool growable: false }) =>
+ List<Number> toList({ bool growable: true }) =>
new List<Number>.from(this, growable: growable);
Set<Number> toSet() => new Set<Number>.from(this);
@@ -4621,7 +4621,7 @@ class PathSegList implements JavaScriptIndexingBehavior, List<PathSeg> native "*
bool any(bool f(PathSeg element)) => IterableMixinWorkaround.any(this, f);
- List<PathSeg> toList({ bool growable: false }) =>
+ List<PathSeg> toList({ bool growable: true }) =>
new List<PathSeg>.from(this, growable: growable);
Set<PathSeg> toSet() => new Set<PathSeg>.from(this);
@@ -5507,7 +5507,7 @@ class StringList implements JavaScriptIndexingBehavior, List<String> native "*SV
bool any(bool f(String element)) => IterableMixinWorkaround.any(this, f);
- List<String> toList({ bool growable: false }) =>
+ List<String> toList({ bool growable: true }) =>
new List<String>.from(this, growable: growable);
Set<String> toSet() => new Set<String>.from(this);
@@ -6671,7 +6671,7 @@ class TransformList implements List<Transform>, JavaScriptIndexingBehavior nativ
bool any(bool f(Transform element)) => IterableMixinWorkaround.any(this, f);
- List<Transform> toList({ bool growable: false }) =>
+ List<Transform> toList({ bool growable: true }) =>
new List<Transform>.from(this, growable: growable);
Set<Transform> toSet() => new Set<Transform>.from(this);
@@ -7190,7 +7190,7 @@ class _ElementInstanceList implements JavaScriptIndexingBehavior, List<ElementIn
bool any(bool f(ElementInstance element)) => IterableMixinWorkaround.any(this, f);
- List<ElementInstance> toList({ bool growable: false }) =>
+ List<ElementInstance> toList({ bool growable: true }) =>
new List<ElementInstance>.from(this, growable: growable);
Set<ElementInstance> toSet() => new Set<ElementInstance>.from(this);
« no previous file with comments | « sdk/lib/html/html_common/filtered_element_list.dart ('k') | sdk/lib/svg/dartium/svg_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698