Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Unified Diff: runtime/lib/array.dart

Issue 12401002: Make List.from and Iterable.toList default to not growable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/serialization/lib/src/serialization_helpers.dart ('k') | runtime/lib/byte_array.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/array.dart
diff --git a/runtime/lib/array.dart b/runtime/lib/array.dart
index 688cfb5e02380e9ee38e4b5c0a10da678da99c7c..a11c59e45363e68bd0aa9a0d70434ec9ebd2cfa9 100644
--- a/runtime/lib/array.dart
+++ b/runtime/lib/array.dart
@@ -228,7 +228,7 @@ class _ObjectArray<E> implements List<E> {
E max([int compare(E a, E b)]) => IterableMixinWorkaround.max(this, compare);
- List<E> toList({ bool growable: false}) {
+ List<E> toList({ bool growable: true}) {
return new List<E>.from(this, growable: growable);
}
@@ -467,7 +467,7 @@ class _ImmutableArray<E> implements List<E> {
E max([int compare(E a, E b)]) => IterableMixinWorkaround.max(this, compare);
- List<E> toList({ bool growable: false }) {
+ List<E> toList({ bool growable: true }) {
return new List<E>.from(this, growable: growable);
}
« no previous file with comments | « pkg/serialization/lib/src/serialization_helpers.dart ('k') | runtime/lib/byte_array.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698