Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 12401002: Make List.from and Iterable.toList default to not growable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « sdk/lib/core/list.dart ('k') | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index b5f053bb405298f757074af33ecdd785be526ca9..32c8ac957aa83c1e378fe1824a9af38d86428c29 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -5926,7 +5926,7 @@ class DataView extends ArrayBufferView native "*DataView" {
@DomName('DataView.getInt8')
@DocsEditable
- Object getInt8({int byteOffset}) native;
+ int getInt8(int byteOffset) native;
@DomName('DataView.getUint16')
@DocsEditable
@@ -5938,7 +5938,7 @@ class DataView extends ArrayBufferView native "*DataView" {
@DomName('DataView.getUint8')
@DocsEditable
- Object getUint8({int byteOffset}) native;
+ int getUint8(int byteOffset) native;
@DomName('DataView.setFloat32')
@DocsEditable
@@ -7153,7 +7153,7 @@ class DomMimeTypeArray implements JavaScriptIndexingBehavior, List<DomMimeType>
bool any(bool f(DomMimeType element)) => IterableMixinWorkaround.any(this, f);
- List<DomMimeType> toList({ bool growable: false }) =>
+ List<DomMimeType> toList({ bool growable: true }) =>
new List<DomMimeType>.from(this, growable: growable);
Set<DomMimeType> toSet() => new Set<DomMimeType>.from(this);
@@ -7409,7 +7409,7 @@ class DomPluginArray implements JavaScriptIndexingBehavior, List<DomPlugin> nati
bool any(bool f(DomPlugin element)) => IterableMixinWorkaround.any(this, f);
- List<DomPlugin> toList({ bool growable: false }) =>
+ List<DomPlugin> toList({ bool growable: true }) =>
new List<DomPlugin>.from(this, growable: growable);
Set<DomPlugin> toSet() => new Set<DomPlugin>.from(this);
@@ -7772,7 +7772,7 @@ class DomStringList implements JavaScriptIndexingBehavior, List<String> native "
bool any(bool f(String element)) => IterableMixinWorkaround.any(this, f);
- List<String> toList({ bool growable: false }) =>
+ List<String> toList({ bool growable: true }) =>
new List<String>.from(this, growable: growable);
Set<String> toSet() => new Set<String>.from(this);
@@ -7974,7 +7974,7 @@ class _ChildrenElementList implements List {
: _childElements = element.$dom_children,
_element = element;
- List<Element> toList({ bool growable: false }) {
+ List<Element> toList({ bool growable: true }) {
List<Element> output;
if (growable) {
output = <Element>[];
@@ -8277,7 +8277,7 @@ class _FrozenElementList implements List {
return false;
}
- List<Element> toList({ bool growable: false }) =>
+ List<Element> toList({ bool growable: true }) =>
new List<Element>.from(this, growable: growable);
Set<Element> toSet() => new Set<Element>.from(this);
@@ -10619,7 +10619,7 @@ class FileList implements JavaScriptIndexingBehavior, List<File> native "*FileLi
bool any(bool f(File element)) => IterableMixinWorkaround.any(this, f);
- List<File> toList({ bool growable: false }) =>
+ List<File> toList({ bool growable: true }) =>
new List<File>.from(this, growable: growable);
Set<File> toSet() => new Set<File>.from(this);
@@ -11178,7 +11178,7 @@ class Float32Array extends ArrayBufferView implements JavaScriptIndexingBehavior
bool any(bool f(num element)) => IterableMixinWorkaround.any(this, f);
- List<num> toList({ bool growable: false }) =>
+ List<num> toList({ bool growable: true }) =>
new List<num>.from(this, growable: growable);
Set<num> toSet() => new Set<num>.from(this);
@@ -11396,7 +11396,7 @@ class Float64Array extends ArrayBufferView implements JavaScriptIndexingBehavior
bool any(bool f(num element)) => IterableMixinWorkaround.any(this, f);
- List<num> toList({ bool growable: false }) =>
+ List<num> toList({ bool growable: true }) =>
new List<num>.from(this, growable: growable);
Set<num> toSet() => new Set<num>.from(this);
@@ -12033,7 +12033,7 @@ class HtmlAllCollection implements JavaScriptIndexingBehavior, List<Node> native
bool any(bool f(Node element)) => IterableMixinWorkaround.any(this, f);
- List<Node> toList({ bool growable: false }) =>
+ List<Node> toList({ bool growable: true }) =>
new List<Node>.from(this, growable: growable);
Set<Node> toSet() => new Set<Node>.from(this);
@@ -12242,7 +12242,7 @@ class HtmlCollection implements JavaScriptIndexingBehavior, List<Node> native "*
bool any(bool f(Node element)) => IterableMixinWorkaround.any(this, f);
- List<Node> toList({ bool growable: false }) =>
+ List<Node> toList({ bool growable: true }) =>
new List<Node>.from(this, growable: growable);
Set<Node> toSet() => new Set<Node>.from(this);
@@ -14234,7 +14234,7 @@ class Int16Array extends ArrayBufferView implements JavaScriptIndexingBehavior,
bool any(bool f(int element)) => IterableMixinWorkaround.any(this, f);
- List<int> toList({ bool growable: false }) =>
+ List<int> toList({ bool growable: true }) =>
new List<int>.from(this, growable: growable);
Set<int> toSet() => new Set<int>.from(this);
@@ -14452,7 +14452,7 @@ class Int32Array extends ArrayBufferView implements JavaScriptIndexingBehavior,
bool any(bool f(int element)) => IterableMixinWorkaround.any(this, f);
- List<int> toList({ bool growable: false }) =>
+ List<int> toList({ bool growable: true }) =>
new List<int>.from(this, growable: growable);
Set<int> toSet() => new Set<int>.from(this);
@@ -14670,7 +14670,7 @@ class Int8Array extends ArrayBufferView implements JavaScriptIndexingBehavior, L
bool any(bool f(int element)) => IterableMixinWorkaround.any(this, f);
- List<int> toList({ bool growable: false }) =>
+ List<int> toList({ bool growable: true }) =>
new List<int>.from(this, growable: growable);
Set<int> toSet() => new Set<int>.from(this);
@@ -17189,7 +17189,7 @@ class _ChildNodeListLazy implements List {
bool any(bool f(Node element)) => IterableMixinWorkaround.any(this, f);
- List<Node> toList({ bool growable: false }) =>
+ List<Node> toList({ bool growable: true }) =>
new List<Node>.from(this, growable: growable);
Set<Node> toSet() => new Set<Node>.from(this);
@@ -17574,7 +17574,7 @@ class NodeList implements JavaScriptIndexingBehavior, List<Node> native "*NodeLi
bool any(bool f(Node element)) => IterableMixinWorkaround.any(this, f);
- List<Node> toList({ bool growable: false }) =>
+ List<Node> toList({ bool growable: true }) =>
new List<Node>.from(this, growable: growable);
Set<Node> toSet() => new Set<Node>.from(this);
@@ -19928,7 +19928,7 @@ class SourceBufferList extends EventTarget implements JavaScriptIndexingBehavior
bool any(bool f(SourceBuffer element)) => IterableMixinWorkaround.any(this, f);
- List<SourceBuffer> toList({ bool growable: false }) =>
+ List<SourceBuffer> toList({ bool growable: true }) =>
new List<SourceBuffer>.from(this, growable: growable);
Set<SourceBuffer> toSet() => new Set<SourceBuffer>.from(this);
@@ -20210,7 +20210,7 @@ class SpeechGrammarList implements JavaScriptIndexingBehavior, List<SpeechGramma
bool any(bool f(SpeechGrammar element)) => IterableMixinWorkaround.any(this, f);
- List<SpeechGrammar> toList({ bool growable: false }) =>
+ List<SpeechGrammar> toList({ bool growable: true }) =>
new List<SpeechGrammar>.from(this, growable: growable);
Set<SpeechGrammar> toSet() => new Set<SpeechGrammar>.from(this);
@@ -21590,7 +21590,7 @@ class TextTrackCueList implements List<TextTrackCue>, JavaScriptIndexingBehavior
bool any(bool f(TextTrackCue element)) => IterableMixinWorkaround.any(this, f);
- List<TextTrackCue> toList({ bool growable: false }) =>
+ List<TextTrackCue> toList({ bool growable: true }) =>
new List<TextTrackCue>.from(this, growable: growable);
Set<TextTrackCue> toSet() => new Set<TextTrackCue>.from(this);
@@ -21797,7 +21797,7 @@ class TextTrackList extends EventTarget implements JavaScriptIndexingBehavior, L
bool any(bool f(TextTrack element)) => IterableMixinWorkaround.any(this, f);
- List<TextTrack> toList({ bool growable: false }) =>
+ List<TextTrack> toList({ bool growable: true }) =>
new List<TextTrack>.from(this, growable: growable);
Set<TextTrack> toSet() => new Set<TextTrack>.from(this);
@@ -22211,7 +22211,7 @@ class TouchList implements JavaScriptIndexingBehavior, List<Touch> native "*Touc
bool any(bool f(Touch element)) => IterableMixinWorkaround.any(this, f);
- List<Touch> toList({ bool growable: false }) =>
+ List<Touch> toList({ bool growable: true }) =>
new List<Touch>.from(this, growable: growable);
Set<Touch> toSet() => new Set<Touch>.from(this);
@@ -22659,7 +22659,7 @@ class Uint16Array extends ArrayBufferView implements JavaScriptIndexingBehavior,
bool any(bool f(int element)) => IterableMixinWorkaround.any(this, f);
- List<int> toList({ bool growable: false }) =>
+ List<int> toList({ bool growable: true }) =>
new List<int>.from(this, growable: growable);
Set<int> toSet() => new Set<int>.from(this);
@@ -22877,7 +22877,7 @@ class Uint32Array extends ArrayBufferView implements JavaScriptIndexingBehavior,
bool any(bool f(int element)) => IterableMixinWorkaround.any(this, f);
- List<int> toList({ bool growable: false }) =>
+ List<int> toList({ bool growable: true }) =>
new List<int>.from(this, growable: growable);
Set<int> toSet() => new Set<int>.from(this);
@@ -23095,7 +23095,7 @@ class Uint8Array extends ArrayBufferView implements JavaScriptIndexingBehavior,
bool any(bool f(int element)) => IterableMixinWorkaround.any(this, f);
- List<int> toList({ bool growable: false }) =>
+ List<int> toList({ bool growable: true }) =>
new List<int>.from(this, growable: growable);
Set<int> toSet() => new Set<int>.from(this);
@@ -23310,7 +23310,7 @@ class Uint8ClampedArray extends Uint8Array implements JavaScriptIndexingBehavior
bool any(bool f(int element)) => IterableMixinWorkaround.any(this, f);
- List<int> toList({ bool growable: false }) =>
+ List<int> toList({ bool growable: true }) =>
new List<int>.from(this, growable: growable);
Set<int> toSet() => new Set<int>.from(this);
@@ -27036,7 +27036,7 @@ class _ClientRectList implements JavaScriptIndexingBehavior, List<ClientRect> na
bool any(bool f(ClientRect element)) => IterableMixinWorkaround.any(this, f);
- List<ClientRect> toList({ bool growable: false }) =>
+ List<ClientRect> toList({ bool growable: true }) =>
new List<ClientRect>.from(this, growable: growable);
Set<ClientRect> toSet() => new Set<ClientRect>.from(this);
@@ -27235,7 +27235,7 @@ class _CssRuleList implements JavaScriptIndexingBehavior, List<CssRule> native "
bool any(bool f(CssRule element)) => IterableMixinWorkaround.any(this, f);
- List<CssRule> toList({ bool growable: false }) =>
+ List<CssRule> toList({ bool growable: true }) =>
new List<CssRule>.from(this, growable: growable);
Set<CssRule> toSet() => new Set<CssRule>.from(this);
@@ -27434,7 +27434,7 @@ class _CssValueList extends CssValue implements List<CssValue>, JavaScriptIndexi
bool any(bool f(CssValue element)) => IterableMixinWorkaround.any(this, f);
- List<CssValue> toList({ bool growable: false }) =>
+ List<CssValue> toList({ bool growable: true }) =>
new List<CssValue>.from(this, growable: growable);
Set<CssValue> toSet() => new Set<CssValue>.from(this);
@@ -27633,7 +27633,7 @@ class _EntryArray implements JavaScriptIndexingBehavior, List<Entry> native "*En
bool any(bool f(Entry element)) => IterableMixinWorkaround.any(this, f);
- List<Entry> toList({ bool growable: false }) =>
+ List<Entry> toList({ bool growable: true }) =>
new List<Entry>.from(this, growable: growable);
Set<Entry> toSet() => new Set<Entry>.from(this);
@@ -27832,7 +27832,7 @@ class _EntryArraySync implements JavaScriptIndexingBehavior, List<EntrySync> nat
bool any(bool f(EntrySync element)) => IterableMixinWorkaround.any(this, f);
- List<EntrySync> toList({ bool growable: false }) =>
+ List<EntrySync> toList({ bool growable: true }) =>
new List<EntrySync>.from(this, growable: growable);
Set<EntrySync> toSet() => new Set<EntrySync>.from(this);
@@ -28031,7 +28031,7 @@ class _GamepadList implements JavaScriptIndexingBehavior, List<Gamepad> native "
bool any(bool f(Gamepad element)) => IterableMixinWorkaround.any(this, f);
- List<Gamepad> toList({ bool growable: false }) =>
+ List<Gamepad> toList({ bool growable: true }) =>
new List<Gamepad>.from(this, growable: growable);
Set<Gamepad> toSet() => new Set<Gamepad>.from(this);
@@ -28293,7 +28293,7 @@ class _NamedNodeMap implements JavaScriptIndexingBehavior, List<Node> native "*N
bool any(bool f(Node element)) => IterableMixinWorkaround.any(this, f);
- List<Node> toList({ bool growable: false }) =>
+ List<Node> toList({ bool growable: true }) =>
new List<Node>.from(this, growable: growable);
Set<Node> toSet() => new Set<Node>.from(this);
@@ -28516,7 +28516,7 @@ class _SpeechInputResultList implements JavaScriptIndexingBehavior, List<SpeechI
bool any(bool f(SpeechInputResult element)) => IterableMixinWorkaround.any(this, f);
- List<SpeechInputResult> toList({ bool growable: false }) =>
+ List<SpeechInputResult> toList({ bool growable: true }) =>
new List<SpeechInputResult>.from(this, growable: growable);
Set<SpeechInputResult> toSet() => new Set<SpeechInputResult>.from(this);
@@ -28715,7 +28715,7 @@ class _SpeechRecognitionResultList implements JavaScriptIndexingBehavior, List<S
bool any(bool f(SpeechRecognitionResult element)) => IterableMixinWorkaround.any(this, f);
- List<SpeechRecognitionResult> toList({ bool growable: false }) =>
+ List<SpeechRecognitionResult> toList({ bool growable: true }) =>
new List<SpeechRecognitionResult>.from(this, growable: growable);
Set<SpeechRecognitionResult> toSet() => new Set<SpeechRecognitionResult>.from(this);
@@ -28914,7 +28914,7 @@ class _StyleSheetList implements JavaScriptIndexingBehavior, List<StyleSheet> na
bool any(bool f(StyleSheet element)) => IterableMixinWorkaround.any(this, f);
- List<StyleSheet> toList({ bool growable: false }) =>
+ List<StyleSheet> toList({ bool growable: true }) =>
new List<StyleSheet>.from(this, growable: growable);
Set<StyleSheet> toSet() => new Set<StyleSheet>.from(this);
@@ -29546,7 +29546,7 @@ abstract class CssClassSet implements Set<String> {
String get first => readClasses().first;
String get last => readClasses().last;
String get single => readClasses().single;
- List<String> toList({ bool growable: false }) =>
+ List<String> toList({ bool growable: true }) =>
readClasses().toList(growable: growable);
Set<String> toSet() => readClasses().toSet();
String min([int compare(String a, String b)]) =>
@@ -31659,7 +31659,7 @@ class _WrappedList<E> implements List<E> {
bool any(bool f(E element)) => _list.any(f);
- List<E> toList({ bool growable: false }) =>
+ List<E> toList({ bool growable: true }) =>
new List.from(_list, growable: growable);
Set<E> toSet() => _list.toSet();
« no previous file with comments | « sdk/lib/core/list.dart ('k') | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698