sdk/lib/_internal/compiler/implementation/ssa/bailout.dart - Issue 12401002: Make List.from and Iterable.toList default to not growable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/bailout.dart

Issue 12401002: Make List.from and Iterable.toList default to not growable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart ('k') | sdk/lib/_internal/compiler/implementation/util/link.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/bailout.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/bailout.dart b/sdk/lib/_internal/compiler/implementation/ssa/bailout.dart

index c7e40180c7ad17982c62c223c9700d7f60254cb1..78ecae65c5098b5de7f79599f1621398ef826a17 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/bailout.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/bailout.dart

@@ -21,8 +21,7 @@ class Environment {

loopMarkers = new List<HBasicBlock>();

Environment.from(Environment other)

: lives = new Set<HInstruction>.from(other.lives),

- loopMarkers = new List<HBasicBlock>.from(other.loopMarkers,

- growable: true);

+ loopMarkers = new List<HBasicBlock>.from(other.loopMarkers);

void remove(HInstruction instruction) {

lives.remove(instruction);