sdk/lib/html/html_common/filtered_element_list.dart - Issue 12401002: Make List.from and Iterable.toList default to not growable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/html_common/filtered_element_list.dart

Issue 12401002: Make List.from and Iterable.toList default to not growable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/html/html_common/filtered_element_list.dart

diff --git a/sdk/lib/html/html_common/filtered_element_list.dart b/sdk/lib/html/html_common/filtered_element_list.dart

index 2883cf76d9535885057eb8b0cee03959315b171b..bc0a6af1c790e923df5fd01b0f548e16f7a8c4de 100644

--- a/sdk/lib/html/html_common/filtered_element_list.dart

+++ b/sdk/lib/html/html_common/filtered_element_list.dart

@@ -147,7 +147,7 @@ class FilteredElementList implements List {

}

bool every(bool f(Element element)) => _filtered.every(f);

bool any(bool f(Element element)) => _filtered.any(f);

- List<Element> toList({ bool growable: false }) =>

+ List<Element> toList({ bool growable: true }) =>

new List<Element>.from(this, growable: growable);

Set<Element> toSet() => new Set<Element>.from(this);

Element firstMatching(bool test(Element value), {Element orElse()}) {

« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | sdk/lib/svg/dart2js/svg_dart2js.dart » ('j') | no next file with comments »