Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1159003002: Make several service protocol RPCs private. (Closed)

Created:
5 years, 7 months ago by turnidge
Modified:
5 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org, Chris Bracken
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -67 lines) Patch
M runtime/observatory/lib/src/elements/code_view.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_map.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M runtime/observatory/tests/service/coverage_test.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/observatory/tests/service/get_flag_list_rpc_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/get_heap_map_rpc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/metrics_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/native_metrics_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/service.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M runtime/vm/service/service.md View 4 chunks +0 lines, -21 lines 0 comments Download
M runtime/vm/service_test.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
turnidge
5 years, 7 months ago (2015-05-27 18:14:58 UTC) #2
rmacnak
lgtm
5 years, 7 months ago (2015-05-27 18:17:50 UTC) #3
turnidge
Chris - Heads up -- this CL will break code coverage... The name of the ...
5 years, 7 months ago (2015-05-27 18:21:40 UTC) #4
turnidge
5 years, 7 months ago (2015-05-27 18:26:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
95dc56e27ec7d32b814e907f983abcdec15cc2c9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698