Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1159003002: Make several service protocol RPCs private. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index e9ecdee1ee11eb204969663d15a4f0a2de64b031..d2c970371707dacb378dfda71c53e6431c451d37 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -1018,7 +1018,7 @@ class Isolate extends ServiceObjectOwner with Coverage {
if (_snapshotFetch == null || _snapshotFetch.isClosed) {
_snapshotFetch = new StreamController();
// isolate.vm.streamListen('_Graph');
- isolate.invokeRpcNoUpgrade('requestHeapSnapshot', {});
+ isolate.invokeRpcNoUpgrade('_requestHeapSnapshot', {});
}
return _snapshotFetch.stream;
}
@@ -1094,7 +1094,7 @@ class Isolate extends ServiceObjectOwner with Coverage {
}
Future<TagProfile> updateTagProfile() {
- return isolate.invokeRpcNoUpgrade('getTagProfile', {}).then(
+ return isolate.invokeRpcNoUpgrade('_getTagProfile', {}).then(
(ObservableMap map) {
var seconds = new DateTime.now().millisecondsSinceEpoch / 1000.0;
tagProfile._processTagProfile(seconds, map);
@@ -1289,7 +1289,7 @@ class Isolate extends ServiceObjectOwner with Coverage {
Map params = {
'onlyWithInstantiations': onlyWithInstantiations,
};
- return invokeRpc('getTypeArgumentsList', params);
+ return invokeRpc('_getTypeArgumentsList', params);
}
Future<ServiceObject> getInstances(Class cls, var limit) {
@@ -1305,7 +1305,7 @@ class Isolate extends ServiceObjectOwner with Coverage {
'address': address,
'ref': ref,
};
- return invokeRpc('getObjectByAddress', params);
+ return invokeRpc('_getObjectByAddress', params);
}
final ObservableMap<String, ServiceMetric> dartMetrics =
@@ -1317,7 +1317,7 @@ class Isolate extends ServiceObjectOwner with Coverage {
Future<ObservableMap<String, ServiceMetric>> _refreshMetrics(
String metricType,
ObservableMap<String, ServiceMetric> metricsMap) {
- return invokeRpc('getIsolateMetricList',
+ return invokeRpc('_getIsolateMetricList',
{ 'type': metricType }).then((result) {
// Clear metrics map.
metricsMap.clear();
@@ -3049,7 +3049,7 @@ class ServiceMetric extends ServiceObject {
Future<ObservableMap> _fetchDirect() {
assert(owner is Isolate);
- return isolate.invokeRpcNoUpgrade('getIsolateMetric', { 'metricId': id });
+ return isolate.invokeRpcNoUpgrade('_getIsolateMetric', { 'metricId': id });
}
« no previous file with comments | « runtime/observatory/lib/src/elements/heap_map.dart ('k') | runtime/observatory/tests/service/coverage_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698