Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: runtime/observatory/tests/service/metrics_test.dart

Issue 1159003002: Make several service protocol RPCs private. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/metrics_test.dart
diff --git a/runtime/observatory/tests/service/metrics_test.dart b/runtime/observatory/tests/service/metrics_test.dart
index 0d0535ea8287c3c96f24da712ce62723d639bbb1..2d3272f0fc7e617cdf066cce0605e53a33c01798 100644
--- a/runtime/observatory/tests/service/metrics_test.dart
+++ b/runtime/observatory/tests/service/metrics_test.dart
@@ -28,7 +28,7 @@ var tests = [
(Isolate isolate) async {
var params = { 'metricId': 'metrics/a.b.c' };
ServiceMetric counter =
- await isolate.invokeRpc('getIsolateMetric', params);
+ await isolate.invokeRpc('_getIsolateMetric', params);
expect(counter.name, equals('a.b.c'));
expect(counter.value, equals(1234.5));
},
@@ -36,14 +36,14 @@ var tests = [
(Isolate isolate) async {
bool caughtException;
try {
- await isolate.invokeRpc('getIsolateMetric',
+ await isolate.invokeRpc('_getIsolateMetric',
{ 'metricId': 'metrics/a.b.d' });
expect(false, isTrue, reason:'Unreachable');
} on ServerRpcException catch (e) {
caughtException = true;
expect(e.code, equals(ServerRpcException.kInvalidParams));
expect(e.message,
- "getIsolateMetric: invalid 'metricId' parameter: metrics/a.b.d");
+ "_getIsolateMetric: invalid 'metricId' parameter: metrics/a.b.d");
}
expect(caughtException, isTrue);
},

Powered by Google App Engine
This is Rietveld 408576698