Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: runtime/observatory/tests/service/native_metrics_test.dart

Issue 1159003002: Make several service protocol RPCs private. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/observatory/tests/service/metrics_test.dart ('k') | runtime/vm/service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // VMOptions=--compile-all --error_on_bad_type --error_on_bad_override 4 // VMOptions=--compile-all --error_on_bad_type --error_on_bad_override
5 5
6 import 'package:observatory/service_io.dart'; 6 import 'package:observatory/service_io.dart';
7 import 'package:unittest/unittest.dart'; 7 import 'package:unittest/unittest.dart';
8 import 'test_helper.dart'; 8 import 'test_helper.dart';
9 9
10 import 'dart:profiler'; 10 import 'dart:profiler';
(...skipping 11 matching lines...) Expand all
22 expect(metrics.length, greaterThan(1)); 22 expect(metrics.length, greaterThan(1));
23 expect(metrics.length, greaterThan(1)); 23 expect(metrics.length, greaterThan(1));
24 var foundOldHeapCapacity = metrics.values.any( 24 var foundOldHeapCapacity = metrics.values.any(
25 (m) => m.name == 'heap.old.capacity'); 25 (m) => m.name == 'heap.old.capacity');
26 expect(foundOldHeapCapacity, equals(true)); 26 expect(foundOldHeapCapacity, equals(true));
27 }, 27 },
28 28
29 (Isolate isolate) async { 29 (Isolate isolate) async {
30 var params = { 'metricId': 'metrics/native/heap.old.used' }; 30 var params = { 'metricId': 'metrics/native/heap.old.used' };
31 ServiceMetric counter = 31 ServiceMetric counter =
32 await isolate.invokeRpc('getIsolateMetric', params); 32 await isolate.invokeRpc('_getIsolateMetric', params);
33 expect(counter.type, equals('Counter')); 33 expect(counter.type, equals('Counter'));
34 expect(counter.name, equals('heap.old.used')); 34 expect(counter.name, equals('heap.old.used'));
35 }, 35 },
36 36
37 (Isolate isolate) async { 37 (Isolate isolate) async {
38 bool caughtException; 38 bool caughtException;
39 try { 39 try {
40 await isolate.invokeRpc('getIsolateMetric', 40 await isolate.invokeRpc('_getIsolateMetric',
41 { 'metricId': 'metrics/native/doesnotexist' }); 41 { 'metricId': 'metrics/native/doesnotexist' });
42 expect(false, isTrue, reason:'Unreachable'); 42 expect(false, isTrue, reason:'Unreachable');
43 } on ServerRpcException catch (e) { 43 } on ServerRpcException catch (e) {
44 caughtException = true; 44 caughtException = true;
45 expect(e.code, equals(ServerRpcException.kInvalidParams)); 45 expect(e.code, equals(ServerRpcException.kInvalidParams));
46 expect(e.message, 46 expect(e.message,
47 "getIsolateMetric: invalid 'metricId' " 47 "_getIsolateMetric: invalid 'metricId' "
48 "parameter: metrics/native/doesnotexist"); 48 "parameter: metrics/native/doesnotexist");
49 } 49 }
50 expect(caughtException, isTrue); 50 expect(caughtException, isTrue);
51 }, 51 },
52 52
53 ]; 53 ];
54 54
55 main(args) => runIsolateTests(args, tests, testeeBefore: script); 55 main(args) => runIsolateTests(args, tests, testeeBefore: script);
OLDNEW
« no previous file with comments | « runtime/observatory/tests/service/metrics_test.dart ('k') | runtime/vm/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698