Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Unified Diff: runtime/observatory/tests/service/native_metrics_test.dart

Issue 1159003002: Make several service protocol RPCs private. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/metrics_test.dart ('k') | runtime/vm/service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/native_metrics_test.dart
diff --git a/runtime/observatory/tests/service/native_metrics_test.dart b/runtime/observatory/tests/service/native_metrics_test.dart
index 0a84204d43b732817458fc377569ecb58c436639..4a7182e48736e32c764e492f10e7ca2285f16387 100644
--- a/runtime/observatory/tests/service/native_metrics_test.dart
+++ b/runtime/observatory/tests/service/native_metrics_test.dart
@@ -29,7 +29,7 @@ var tests = [
(Isolate isolate) async {
var params = { 'metricId': 'metrics/native/heap.old.used' };
ServiceMetric counter =
- await isolate.invokeRpc('getIsolateMetric', params);
+ await isolate.invokeRpc('_getIsolateMetric', params);
expect(counter.type, equals('Counter'));
expect(counter.name, equals('heap.old.used'));
},
@@ -37,14 +37,14 @@ var tests = [
(Isolate isolate) async {
bool caughtException;
try {
- await isolate.invokeRpc('getIsolateMetric',
+ await isolate.invokeRpc('_getIsolateMetric',
{ 'metricId': 'metrics/native/doesnotexist' });
expect(false, isTrue, reason:'Unreachable');
} on ServerRpcException catch (e) {
caughtException = true;
expect(e.code, equals(ServerRpcException.kInvalidParams));
expect(e.message,
- "getIsolateMetric: invalid 'metricId' "
+ "_getIsolateMetric: invalid 'metricId' "
"parameter: metrics/native/doesnotexist");
}
expect(caughtException, isTrue);
« no previous file with comments | « runtime/observatory/tests/service/metrics_test.dart ('k') | runtime/vm/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698