runtime/observatory/tests/service/get_flag_list_rpc_test.dart - Issue 1159003002: Make several service protocol RPCs private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/get_flag_list_rpc_test.dart

Issue 1159003002: Make several service protocol RPCs private. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/tests/service/get_flag_list_rpc_test.dart

diff --git a/runtime/observatory/tests/service/get_flag_list_rpc_test.dart b/runtime/observatory/tests/service/get_flag_list_rpc_test.dart

index d726c2be6b3df5bc5a694f0c32c676d590ac2c9a..f05def62ee3789782045b973b55b7e3e47696965 100644

--- a/runtime/observatory/tests/service/get_flag_list_rpc_test.dart

+++ b/runtime/observatory/tests/service/get_flag_list_rpc_test.dart

@@ -22,7 +22,7 @@ var tests = [

'name' : 'does_not_really_exist',

'value' : 'true',

};

- var result = await vm.invokeRpcNoUpgrade('setFlag', params);

+ var result = await vm.invokeRpcNoUpgrade('_setFlag', params);

expect(result['type'], equals('Error'));

expect(result['message'], equals('Cannot set flag: flag not found'));

@@ -34,7 +34,7 @@ var tests = [

'name' : 'trace_isolates',

'value' : '123',

};

- var result = await vm.invokeRpcNoUpgrade('setFlag', params);

+ var result = await vm.invokeRpcNoUpgrade('_setFlag', params);

expect(result['type'], equals('Error'));

expect(result['message'], equals('Cannot set flag: invalid value'));