Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 1154163004: Libraries have uris not urls. Scripts have uris not names. (Closed)

Created:
5 years, 7 months ago by rmacnak
Modified:
5 years, 7 months ago
Reviewers:
turnidge, Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Libraries have uris not urls. Scripts have uris not names. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/1fa8c92f314dd64e256cddbebc04446af0ae18ef

Patch Set 1 #

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -48 lines) Patch
M runtime/observatory/lib/src/elements/library_view.html View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 7 chunks +16 lines, -16 lines 0 comments Download
M runtime/observatory/tests/service/allocations_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/get_object_rpc_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/coverage_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/debugger_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M runtime/vm/object_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/report_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/service/service.md View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 7 months ago (2015-05-26 22:49:45 UTC) #2
Cutch
lgtm
5 years, 7 months ago (2015-05-26 22:56:14 UTC) #3
rmacnak
5 years, 7 months ago (2015-05-26 23:03:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1fa8c92f314dd64e256cddbebc04446af0ae18ef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698