Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3326)

Unified Diff: runtime/vm/report_test.cc

Issue 1154163004: Libraries have uris not urls. Scripts have uris not names. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: sync Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/service/service.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/report_test.cc
diff --git a/runtime/vm/report_test.cc b/runtime/vm/report_test.cc
index b17905541a3a8c4941e49aacf98ff0fadf6ecd82..cc086ff13021130317050dacf5b6e75068f4b20b 100644
--- a/runtime/vm/report_test.cc
+++ b/runtime/vm/report_test.cc
@@ -31,7 +31,7 @@ TEST_CASE(TraceJSWarning) {
EXPECT_SUBSTRING("\"message\":{\"type\":\"JSCompatibilityWarning\","
"\"script\":{\"type\":\"@Script\",\"id\":"
"\"libraries\\/-1\\/scripts\\/Plug\","
- "\"name\":\"Plug\","
+ "\"uri\":\"Plug\","
"\"kind\":\"script\"},\"tokenPos\":0,"
"\"message\":{\"type\":\"@String\"",
js.ToCString());
@@ -48,7 +48,7 @@ TEST_CASE(TraceJSWarning) {
EXPECT_EQ(2, trace_buffer->Length());
EXPECT_SUBSTRING("{\"type\":\"JSCompatibilityWarning\",\"script\":{\"type\":"
"\"@Script\",\"id\":\"libraries\\/-1\\/scripts\\/Plug\","
- "\"name\":\"Plug\","
+ "\"uri\":\"Plug\","
"\"kind\":\"script\"},\"tokenPos\":0,"
"\"message\":{\"type\":\"@String\"",
trace_buffer->At(0)->message);
@@ -58,7 +58,7 @@ TEST_CASE(TraceJSWarning) {
EXPECT_SUBSTRING("{\"type\":\"JSCompatibilityWarning\",\"script\":{\"type\":"
"\"@Script\",\"id\":\"libraries\\/-1\\/scripts\\/Plug\","
- "\"name\":\"Plug\","
+ "\"uri\":\"Plug\","
"\"kind\":\"script\"},\"tokenPos\":1,"
"\"message\":{\"type\":\"@String\"",
trace_buffer->At(1)->message);
« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/service/service.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698