runtime/observatory/tests/service/allocations_test.dart - Issue 1154163004: Libraries have uris not urls. Scripts have uris not names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/allocations_test.dart

Issue 1154163004: Libraries have uris not urls. Scripts have uris not names. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: sync Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/tests/service/allocations_test.dart

diff --git a/runtime/observatory/tests/service/allocations_test.dart b/runtime/observatory/tests/service/allocations_test.dart

index f305d89bb1396ffb042432d808744f001a5f8871..0882edc7bce1cbf8d58757502b71b41b565f02f0 100644

--- a/runtime/observatory/tests/service/allocations_test.dart

+++ b/runtime/observatory/tests/service/allocations_test.dart

@@ -21,7 +21,7 @@ var tests = [

(Isolate isolate) =>

isolate.rootLibrary.load().then((Library lib) {

- expect(lib.url.endsWith('allocations_test.dart'), isTrue);

+ expect(lib.uri.endsWith('allocations_test.dart'), isTrue);

expect(lib.classes.length, equals(1));

return lib.classes.first.load().then((Class fooClass) {

expect(fooClass.name, equals('Foo'));