runtime/vm/object_test.cc - Issue 1154163004: Libraries have uris not urls. Scripts have uris not names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object_test.cc

Issue 1154163004: Libraries have uris not urls. Scripts have uris not names. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: sync Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/object_test.cc

diff --git a/runtime/vm/object_test.cc b/runtime/vm/object_test.cc

index 5e72ebfe4343a587f4d3948fe38b15115a0bb715..3b9fb0df1157a57bd34a7e757638a0c65677d7d7 100644

--- a/runtime/vm/object_test.cc

+++ b/runtime/vm/object_test.cc

@@ -4340,7 +4340,7 @@ TEST_CASE(PrintJSONPrimitives) {

elideSubstring("libraries", js.ToCString(), buffer);

EXPECT_STREQ(

"{\"type\":\"@Library\",\"id\":\"\",\"name\":\"dart.core\","

- "\"url\":\"dart:core\"}",

+ "\"uri\":\"dart:core\"}",

buffer);

}

// Bool reference

« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/report_test.cc » ('j') | no next file with comments »