Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: runtime/vm/service/service.md

Issue 1154163004: Libraries have uris not urls. Scripts have uris not names. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: sync Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/report_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service/service.md
diff --git a/runtime/vm/service/service.md b/runtime/vm/service/service.md
index 79bb9e175a5643d9d581d46e5674f5bb865bef19..7a2c52b2ec5223c8ddd063708771d8e2727c6793 100644
--- a/runtime/vm/service/service.md
+++ b/runtime/vm/service/service.md
@@ -1350,8 +1350,8 @@ class @Library extends @Object {
// The name of this library.
string name;
- // The url of this library.
- string url;
+ // The uri of this library.
+ string uri;
}
```
@@ -1362,8 +1362,8 @@ class Library extends Object {
// The name of this library.
string name;
- // The url of this library.
- string url;
+ // The uri of this library.
+ string uri;
// A list of the imports for this library.
@Library[] imports;
@@ -1528,8 +1528,8 @@ A _SentinelType_ is used to distinguish different kinds of _Sentinel_ objects.
```
class @Script extends @Object {
- // A name for this script.
- string name;
+ // The uri from which this script was loaded.
+ string uri;
// What kind of script is this?
string kind;
@@ -1540,8 +1540,8 @@ _@Script_ is a reference to a _Script_.
```
class Script extends Object {
- // A name for this script.
- string name;
+ // The uri from which this script was loaded.
+ string uri;
// What kind of script is this?
ScriptKind kind;
« no previous file with comments | « runtime/vm/report_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698