Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: runtime/observatory/tests/service/get_object_rpc_test.dart

Issue 1154163004: Libraries have uris not urls. Scripts have uris not names. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: sync Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/allocations_test.dart ('k') | runtime/vm/coverage_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/get_object_rpc_test.dart
diff --git a/runtime/observatory/tests/service/get_object_rpc_test.dart b/runtime/observatory/tests/service/get_object_rpc_test.dart
index 2fedac5375b10261fc9abe2ed11a1ed0a602ec2d..75a535cb385f83eb13ec883d4d447646e65daf44 100644
--- a/runtime/observatory/tests/service/get_object_rpc_test.dart
+++ b/runtime/observatory/tests/service/get_object_rpc_test.dart
@@ -123,8 +123,8 @@ var tests = [
expect(result['type'], equals('Library'));
expect(result['id'], startsWith('libraries/'));
expect(result['name'], equals('get_object_rpc_test'));
- expect(result['url'], startsWith('file:'));
- expect(result['url'], endsWith('get_object_rpc_test.dart'));
+ expect(result['uri'], startsWith('file:'));
+ expect(result['uri'], endsWith('get_object_rpc_test.dart'));
expect(result['imports'].length, isPositive);
expect(result['imports'][0]['type'], equals('@Library'));
expect(result['scripts'].length, isPositive);
@@ -169,8 +169,8 @@ var tests = [
var result = await isolate.invokeRpcNoUpgrade('getObject', params);
expect(result['type'], equals('Script'));
expect(result['id'], startsWith('libraries/'));
- expect(result['name'], startsWith('file:'));
- expect(result['name'], endsWith('get_object_rpc_test.dart'));
+ expect(result['uri'], startsWith('file:'));
+ expect(result['uri'], endsWith('get_object_rpc_test.dart'));
expect(result['kind'], equals('script'));
expect(result['library']['type'], equals('@Library'));
expect(result['source'], startsWith('// Copyright (c)'));
« no previous file with comments | « runtime/observatory/tests/service/allocations_test.dart ('k') | runtime/vm/coverage_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698