Issue 9826010: Made a ScopedMockUserManagerEnabler to simplify UserManager mocking life-cycle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9826010: Made a ScopedMockUserManagerEnabler to simplify UserManager mocking life-cycle. (Closed)

Created:
8 years, 9 months ago by pastarmovj

Modified:
8 years, 9 months ago

Reviewers:
Nikita (slow), zel

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Made a ScopedMockUserManagerEnabler to simplify UserManager mocking life-cycle. BUG=none TEST=unit_tests,browser_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128870

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -35 lines)			Patch
M	chrome/browser/browser_commands_unittest.cc	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/cros/onc_network_parser_unittest.cc	View	3 chunks	+4 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/cros_settings_unittest.cc	View	3 chunks	+2 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver_unittest.cc	View	3 chunks	+2 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/login/existing_user_controller_browsertest.cc	View	4 chunks	+5 lines, -11 lines	0 comments	Download
M	chrome/browser/chromeos/login/mock_user_manager.h	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/mock_user_manager.cc	View	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

pastarmovj

Please review this CL that makes the UserManager mocking easier, because users don't have to ...

8 years, 9 months ago (2012-03-22 13:24:52 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/9826010/1

8 years, 9 months ago (2012-03-23 15:38:16 UTC) #4

commit-bot: I haz the power

8 years, 9 months ago (2012-03-23 18:54:12 UTC) #5

Try job failure for 9826010-1 (retry) on win_rel for step
"installer_util_unittests".
It's a second try, previously, steps "browser_tests, installer_util_unittests"
failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages