Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: chrome/browser/chromeos/login/existing_user_controller_browsertest.cc

Issue 9826010: Made a ScopedMockUserManagerEnabler to simplify UserManager mocking life-cycle. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
diff --git a/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc b/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
index 8887e6ee6725a3ade1541c850b0067e0821d70fb..1d11abb8dd167ca452d724bcbe727ce8d9ed977d 100644
--- a/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
+++ b/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
@@ -100,7 +100,6 @@ class ExistingUserControllerTest : public CrosInProcessBrowserTest {
mock_network_library_(NULL),
mock_login_display_(NULL),
mock_login_display_host_(NULL),
- mock_user_manager_(NULL),
testing_profile_(NULL) {
}
@@ -145,18 +144,16 @@ class ExistingUserControllerTest : public CrosInProcessBrowserTest {
mock_login_display_.reset(new MockLoginDisplay());
mock_login_display_host_.reset(new MockLoginDisplayHost());
- mock_user_manager_.reset(new MockUserManager());
- old_user_manager_ = UserManager::Set(mock_user_manager_.get());
- EXPECT_CALL(*mock_user_manager_, IsKnownUser(kUsername))
+ EXPECT_CALL(*mock_user_manager_.user_manager(), IsKnownUser(kUsername))
.Times(AnyNumber())
.WillRepeatedly(Return(true));
- EXPECT_CALL(*mock_user_manager_, IsKnownUser(kNewUsername))
+ EXPECT_CALL(*mock_user_manager_.user_manager(), IsKnownUser(kNewUsername))
.Times(AnyNumber())
.WillRepeatedly(Return(false));
- EXPECT_CALL(*mock_user_manager_, IsUserLoggedIn())
+ EXPECT_CALL(*mock_user_manager_.user_manager(), IsUserLoggedIn())
.Times(AnyNumber())
.WillRepeatedly(Return(false));
- EXPECT_CALL(*mock_user_manager_, IsLoggedInAsGuest())
+ EXPECT_CALL(*mock_user_manager_.user_manager(), IsLoggedInAsGuest())
.Times(AnyNumber())
.WillRepeatedly(Return(false));
@@ -182,7 +179,6 @@ class ExistingUserControllerTest : public CrosInProcessBrowserTest {
}
virtual void TearDownInProcessBrowserTestFixture() OVERRIDE {
- UserManager::Set(old_user_manager_);
CrosInProcessBrowserTest::TearDownInProcessBrowserTestFixture();
DBusThreadManager::Shutdown();
}
@@ -194,9 +190,7 @@ class ExistingUserControllerTest : public CrosInProcessBrowserTest {
scoped_ptr<MockLoginDisplay> mock_login_display_;
scoped_ptr<MockLoginDisplayHost> mock_login_display_host_;
- // Owned by UserManagerImplWrapper.
- scoped_ptr<MockUserManager> mock_user_manager_;
- UserManager* old_user_manager_;
+ ScopedMockUserManagerEnabler mock_user_manager_;
// Owned by LoginUtilsWrapper.
MockLoginUtils* mock_login_utils_;

Powered by Google App Engine
This is Rietveld 408576698