Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2245)

Unified Diff: chrome/browser/chromeos/cros/onc_network_parser_unittest.cc

Issue 9826010: Made a ScopedMockUserManagerEnabler to simplify UserManager mocking life-cycle. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_commands_unittest.cc ('k') | chrome/browser/chromeos/cros_settings_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/cros/onc_network_parser_unittest.cc
diff --git a/chrome/browser/chromeos/cros/onc_network_parser_unittest.cc b/chrome/browser/chromeos/cros/onc_network_parser_unittest.cc
index 740174faefdbe20e22c4cb39c1eb60cbde4a4809..a3d4e6cb945c014223881517870d0fc1a4da8ac8 100644
--- a/chrome/browser/chromeos/cros/onc_network_parser_unittest.cc
+++ b/chrome/browser/chromeos/cros/onc_network_parser_unittest.cc
@@ -885,11 +885,10 @@ TEST_F(OncNetworkParserTest, TestProxySettingsManual) {
}
TEST(OncNetworkParserUserExpansionTest, GetUserExpandedValue) {
- scoped_ptr<MockUserManager> mock_user_manager(new MockUserManager());
- UserManager* old_user_manager = UserManager::Set(mock_user_manager.get());
- mock_user_manager->SetLoggedInUser("onc@example.com", false);
+ ScopedMockUserManagerEnabler mock_user_manager;
+ mock_user_manager.user_manager()->SetLoggedInUser("onc@example.com", false);
- EXPECT_CALL(*mock_user_manager, IsUserLoggedIn())
+ EXPECT_CALL(*mock_user_manager.user_manager(), IsUserLoggedIn())
.Times(2)
.WillRepeatedly(Return(false));
@@ -914,7 +913,7 @@ TEST(OncNetworkParserUserExpansionTest, GetUserExpandedValue) {
login_email_pattern, source));
// Log in a user and check that the expansions work as expected.
- EXPECT_CALL(*mock_user_manager, IsUserLoggedIn())
+ EXPECT_CALL(*mock_user_manager.user_manager(), IsUserLoggedIn())
.Times(2)
.WillRepeatedly(Return(true));
@@ -924,8 +923,6 @@ TEST(OncNetworkParserUserExpansionTest, GetUserExpandedValue) {
EXPECT_EQ("a onc@example.com b",
chromeos::OncNetworkParser::GetUserExpandedValue(
login_email_pattern, source));
-
- UserManager::Set(old_user_manager);
}
} // namespace chromeos
« no previous file with comments | « chrome/browser/browser_commands_unittest.cc ('k') | chrome/browser/chromeos/cros_settings_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698