Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Side by Side Diff: chrome/browser/chromeos/login/existing_user_controller_browsertest.cc

Issue 9826010: Made a ScopedMockUserManagerEnabler to simplify UserManager mocking life-cycle. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/compiler_specific.h" 6 #include "base/compiler_specific.h"
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/message_loop.h" 8 #include "base/message_loop.h"
9 #include "chrome/browser/chromeos/cros/cros_mock.h" 9 #include "chrome/browser/chromeos/cros/cros_mock.h"
10 #include "chrome/browser/chromeos/cros/cros_in_process_browser_test.h" 10 #include "chrome/browser/chromeos/cros/cros_in_process_browser_test.h"
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 DISALLOW_COPY_AND_ASSIGN(MockLoginDisplayHost); 93 DISALLOW_COPY_AND_ASSIGN(MockLoginDisplayHost);
94 }; 94 };
95 95
96 class ExistingUserControllerTest : public CrosInProcessBrowserTest { 96 class ExistingUserControllerTest : public CrosInProcessBrowserTest {
97 protected: 97 protected:
98 ExistingUserControllerTest() 98 ExistingUserControllerTest()
99 : mock_cryptohome_library_(NULL), 99 : mock_cryptohome_library_(NULL),
100 mock_network_library_(NULL), 100 mock_network_library_(NULL),
101 mock_login_display_(NULL), 101 mock_login_display_(NULL),
102 mock_login_display_host_(NULL), 102 mock_login_display_host_(NULL),
103 mock_user_manager_(NULL),
104 testing_profile_(NULL) { 103 testing_profile_(NULL) {
105 } 104 }
106 105
107 ExistingUserController* existing_user_controller() { 106 ExistingUserController* existing_user_controller() {
108 return ExistingUserController::current_controller(); 107 return ExistingUserController::current_controller();
109 } 108 }
110 109
111 virtual void CleanUpOnMainThread() OVERRIDE { 110 virtual void CleanUpOnMainThread() OVERRIDE {
112 CrosInProcessBrowserTest::CleanUpOnMainThread(); 111 CrosInProcessBrowserTest::CleanUpOnMainThread();
113 testing_profile_.reset(NULL); 112 testing_profile_.reset(NULL);
(...skipping 24 matching lines...) Expand all
138 mock_login_utils_ = new MockLoginUtils(); 137 mock_login_utils_ = new MockLoginUtils();
139 LoginUtils::Set(mock_login_utils_); 138 LoginUtils::Set(mock_login_utils_);
140 EXPECT_CALL(*mock_login_utils_, PrewarmAuthentication()) 139 EXPECT_CALL(*mock_login_utils_, PrewarmAuthentication())
141 .Times(AnyNumber()); 140 .Times(AnyNumber());
142 EXPECT_CALL(*mock_login_utils_, StopBackgroundFetchers()) 141 EXPECT_CALL(*mock_login_utils_, StopBackgroundFetchers())
143 .Times(AnyNumber()); 142 .Times(AnyNumber());
144 143
145 mock_login_display_.reset(new MockLoginDisplay()); 144 mock_login_display_.reset(new MockLoginDisplay());
146 mock_login_display_host_.reset(new MockLoginDisplayHost()); 145 mock_login_display_host_.reset(new MockLoginDisplayHost());
147 146
148 mock_user_manager_.reset(new MockUserManager()); 147 EXPECT_CALL(*mock_user_manager_.user_manager(), IsKnownUser(kUsername))
149 old_user_manager_ = UserManager::Set(mock_user_manager_.get());
150 EXPECT_CALL(*mock_user_manager_, IsKnownUser(kUsername))
151 .Times(AnyNumber()) 148 .Times(AnyNumber())
152 .WillRepeatedly(Return(true)); 149 .WillRepeatedly(Return(true));
153 EXPECT_CALL(*mock_user_manager_, IsKnownUser(kNewUsername)) 150 EXPECT_CALL(*mock_user_manager_.user_manager(), IsKnownUser(kNewUsername))
154 .Times(AnyNumber()) 151 .Times(AnyNumber())
155 .WillRepeatedly(Return(false)); 152 .WillRepeatedly(Return(false));
156 EXPECT_CALL(*mock_user_manager_, IsUserLoggedIn()) 153 EXPECT_CALL(*mock_user_manager_.user_manager(), IsUserLoggedIn())
157 .Times(AnyNumber()) 154 .Times(AnyNumber())
158 .WillRepeatedly(Return(false)); 155 .WillRepeatedly(Return(false));
159 EXPECT_CALL(*mock_user_manager_, IsLoggedInAsGuest()) 156 EXPECT_CALL(*mock_user_manager_.user_manager(), IsLoggedInAsGuest())
160 .Times(AnyNumber()) 157 .Times(AnyNumber())
161 .WillRepeatedly(Return(false)); 158 .WillRepeatedly(Return(false));
162 159
163 EXPECT_CALL(*mock_login_display_host_.get(), CreateLoginDisplay(_)) 160 EXPECT_CALL(*mock_login_display_host_.get(), CreateLoginDisplay(_))
164 .Times(1) 161 .Times(1)
165 .WillOnce(Return(mock_login_display_.get())); 162 .WillOnce(Return(mock_login_display_.get()));
166 EXPECT_CALL(*mock_login_display_host_.get(), GetNativeWindow()) 163 EXPECT_CALL(*mock_login_display_host_.get(), GetNativeWindow())
167 .Times(1) 164 .Times(1)
168 .WillOnce(ReturnNull()); 165 .WillOnce(ReturnNull());
169 EXPECT_CALL(*mock_login_display_.get(), Init(_, false, true, true)) 166 EXPECT_CALL(*mock_login_display_.get(), Init(_, false, true, true))
170 .Times(1); 167 .Times(1);
171 } 168 }
172 169
173 virtual void SetUpOnMainThread() OVERRIDE { 170 virtual void SetUpOnMainThread() OVERRIDE {
174 testing_profile_.reset(new TestingProfile()); 171 testing_profile_.reset(new TestingProfile());
175 ExistingUserController* controller = 172 ExistingUserController* controller =
176 new ExistingUserController(mock_login_display_host_.get()); 173 new ExistingUserController(mock_login_display_host_.get());
177 controller->Init(UserList()); 174 controller->Init(UserList());
178 profile_prepared_cb_ = 175 profile_prepared_cb_ =
179 base::Bind(&ExistingUserController::OnProfilePrepared, 176 base::Bind(&ExistingUserController::OnProfilePrepared,
180 base::Unretained(existing_user_controller()), 177 base::Unretained(existing_user_controller()),
181 testing_profile_.get()); 178 testing_profile_.get());
182 } 179 }
183 180
184 virtual void TearDownInProcessBrowserTestFixture() OVERRIDE { 181 virtual void TearDownInProcessBrowserTestFixture() OVERRIDE {
185 UserManager::Set(old_user_manager_);
186 CrosInProcessBrowserTest::TearDownInProcessBrowserTestFixture(); 182 CrosInProcessBrowserTest::TearDownInProcessBrowserTestFixture();
187 DBusThreadManager::Shutdown(); 183 DBusThreadManager::Shutdown();
188 } 184 }
189 185
190 // These mocks are owned by CrosLibrary class. 186 // These mocks are owned by CrosLibrary class.
191 MockCryptohomeLibrary* mock_cryptohome_library_; 187 MockCryptohomeLibrary* mock_cryptohome_library_;
192 MockNetworkLibrary* mock_network_library_; 188 MockNetworkLibrary* mock_network_library_;
193 189
194 scoped_ptr<MockLoginDisplay> mock_login_display_; 190 scoped_ptr<MockLoginDisplay> mock_login_display_;
195 scoped_ptr<MockLoginDisplayHost> mock_login_display_host_; 191 scoped_ptr<MockLoginDisplayHost> mock_login_display_host_;
196 192
197 // Owned by UserManagerImplWrapper. 193 ScopedMockUserManagerEnabler mock_user_manager_;
198 scoped_ptr<MockUserManager> mock_user_manager_;
199 UserManager* old_user_manager_;
200 194
201 // Owned by LoginUtilsWrapper. 195 // Owned by LoginUtilsWrapper.
202 MockLoginUtils* mock_login_utils_; 196 MockLoginUtils* mock_login_utils_;
203 197
204 scoped_ptr<TestingProfile> testing_profile_; 198 scoped_ptr<TestingProfile> testing_profile_;
205 199
206 // Mock URLFetcher. 200 // Mock URLFetcher.
207 MockURLFetcherFactory<SuccessFetcher> factory_; 201 MockURLFetcherFactory<SuccessFetcher> factory_;
208 202
209 base::Callback<void(void)> profile_prepared_cb_; 203 base::Callback<void(void)> profile_prepared_cb_;
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 .Times(1); 280 .Times(1);
287 EXPECT_CALL(*mock_login_display_.get(), OnFadeOut()) 281 EXPECT_CALL(*mock_login_display_.get(), OnFadeOut())
288 .Times(1); 282 .Times(1);
289 EXPECT_CALL(*mock_login_display_host_.get(), OnCompleteLogin()) 283 EXPECT_CALL(*mock_login_display_host_.get(), OnCompleteLogin())
290 .Times(1); 284 .Times(1);
291 existing_user_controller()->CompleteLogin(kNewUsername, kPassword); 285 existing_user_controller()->CompleteLogin(kNewUsername, kPassword);
292 ui_test_utils::RunAllPendingInMessageLoop(); 286 ui_test_utils::RunAllPendingInMessageLoop();
293 } 287 }
294 288
295 } // namespace chromeos 289 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698