Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: chrome/browser/chromeos/cros_settings_unittest.cc

Issue 9826010: Made a ScopedMockUserManagerEnabler to simplify UserManager mocking life-cycle. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/cros_settings_unittest.cc
diff --git a/chrome/browser/chromeos/cros_settings_unittest.cc b/chrome/browser/chromeos/cros_settings_unittest.cc
index ce03ea6fa337ebbadf4a5ed5586ed214d4b5bef8..265955e8f66acce6012d074dc9a561bb826a94d2 100644
--- a/chrome/browser/chromeos/cros_settings_unittest.cc
+++ b/chrome/browser/chromeos/cros_settings_unittest.cc
@@ -44,9 +44,7 @@ class CrosSettingsTest : public testing::Test {
}
virtual void SetUp() {
- mock_user_manager_.reset(new MockUserManager());
- old_user_manager_ = UserManager::Set(mock_user_manager_.get());
- EXPECT_CALL(*mock_user_manager_, IsCurrentUserOwner())
+ EXPECT_CALL(*mock_user_manager_.user_manager(), IsCurrentUserOwner())
.Times(AnyNumber())
.WillRepeatedly(Return(true));
// Reset the cache between tests.
@@ -59,7 +57,6 @@ class CrosSettingsTest : public testing::Test {
// Reset the cache between tests.
ApplyEmptyPolicy();
STLDeleteValues(&expected_props_);
- UserManager::Set(old_user_manager_);
}
void FetchPref(const std::string& pref) {
@@ -123,8 +120,7 @@ class CrosSettingsTest : public testing::Test {
ScopedTestingLocalState local_state_;
- scoped_ptr<MockUserManager> mock_user_manager_;
- UserManager* old_user_manager_;
+ ScopedMockUserManagerEnabler mock_user_manager_;
ScopedStubCrosEnabler stub_cros_enabler_;
};

Powered by Google App Engine
This is Rietveld 408576698