Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2365)

Unified Diff: chrome/browser/browser_commands_unittest.cc

Issue 9826010: Made a ScopedMockUserManagerEnabler to simplify UserManager mocking life-cycle. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/cros/onc_network_parser_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_commands_unittest.cc
diff --git a/chrome/browser/browser_commands_unittest.cc b/chrome/browser/browser_commands_unittest.cc
index d783af82f2c3810eb402d287a381ac89e6f1ef76..ea4d1489e9a12ceaa68464940f799a9fb546f5c9 100644
--- a/chrome/browser/browser_commands_unittest.cc
+++ b/chrome/browser/browser_commands_unittest.cc
@@ -182,9 +182,8 @@ TEST_F(BrowserCommandsTest, BackForwardInNewTab) {
namespace chromeos {
TEST_F(BrowserCommandsTest, Search) {
- scoped_ptr<MockUserManager> mock_user_manager(new MockUserManager());
- UserManager* old_user_manager = UserManager::Set(mock_user_manager.get());
- EXPECT_CALL(*mock_user_manager, IsLoggedInAsGuest())
+ ScopedMockUserManagerEnabler mock_user_manager;
+ EXPECT_CALL(*mock_user_manager.user_manager(), IsLoggedInAsGuest())
.Times(1).WillRepeatedly(::testing::Return(false));
// Load a non-NTP URL.
@@ -208,8 +207,6 @@ TEST_F(BrowserCommandsTest, Search) {
current_url = browser()->GetSelectedWebContents()->GetURL();
EXPECT_TRUE(current_url.SchemeIs(chrome::kChromeUIScheme));
EXPECT_EQ(chrome::kChromeUINewTabHost, current_url.host());
-
- UserManager::Set(old_user_manager);
}
} // namespace chromeos
« no previous file with comments | « no previous file | chrome/browser/chromeos/cros/onc_network_parser_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698