Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9114020: Remove task.h and finish base::Bind() migration. (Closed)

Created:
8 years, 11 months ago by awong
Modified:
8 years, 11 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, vrk (LEFT CHROMIUM), jam, sadrul, nkostylev+watch_chromium.org, acolwell+watch_chromium.org, tburkard+watch_chromium.org, dhollowa+watch_chromium.org, amit, yoshiki+watch_chromium.org, mihaip+watch_chromium.org, dcheng, dmazzoni+watch_chromium.org, ajwong+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, cbentzel+watch_chromium.org, ben+watch_chromium.org, aboxhall+watch_chromium.org, ddorwin+watch_chromium.org, kkania, prasadt, apatrick_chromium, joi+watch-content_chromium.org, wez+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, annacc+watch_chromium.org, scherkus (not reviewing), ihf+watch_chromium.org, sanjeevr, michaeln, Avi (use Gerrit), jennb, creis+watch_chromium.org, dtseng+watch_chromium.org, tbarzic+watch_chromium.org, fischman+watch_chromium.org, wtc, rkn, Randy Smith (Not in Mondays), jianli, dpranke-watch+content_chromium.org, simonmorris+watch_chromium.org, pam+watch_chromium.org, yuzo+watch_chromium.org, sergeyu+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, achuith+watch_chromium.org, hashimoto+watch_chromium.org, tfarina, Dmitry Titov, davidbarr+watch_chromium.org, garykac+watch_chromium.org, Aaron Boodman, dominich+watch_chromium.org, lambroslambrou+watch_chromium.org, robertshield, davemoore+watch_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., erikwright (departed), mmenke
Visibility:
Public.

Description

Remove task.h and finish base::Bind() migration. Over 341 CLs, in ~3 months, touching 3251 unique files! Top 5 most CLs: (121) jhawkins ( 45) dcheng ( 24) achuith ( 23) csilv ( 12) tfarina ( 12) groby ~1000 files touched: (918) jhawkins 100+ files touched: (486) ajwong (385) willchan (372) dcheng (126) csilv (123) fischman (112) sergeyu 49+ files touched: (65) tfarina (57) acolwell (52) adamk (49) tzik BUG=35223 TEST=existing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116748

Patch Set 1 #

Patch Set 2 : iwyu fixes since task.h pulled in so many transitive dependencies. #

Patch Set 3 : fix remoting and chrome_frame #

Patch Set 4 : rebased with more compile fixes #

Patch Set 5 : fix one more error #

Patch Set 6 : windows whackamole #

Total comments: 1

Patch Set 7 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -414 lines) Patch
M ash/shell.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/at_exit.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/base.gyp View 2 chunks +1 line, -1 line 0 comments Download
M base/base.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M base/bind_helpers.h View 1 2 3 4 5 6 3 chunks +42 lines, -1 line 0 comments Download
A + base/bind_helpers.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
A + base/bind_helpers_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M base/files/file_path_watcher_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/message_loop.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/message_loop_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/message_loop_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/message_pump_glib_unittest.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M base/observer_list_threadsafe.h View 1 chunk +0 lines, -1 line 0 comments Download
D base/task.h View 1 chunk +0 lines, -69 lines 0 comments Download
D base/task.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D base/task_unittest.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M base/threading/worker_pool_posix.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/threading/worker_pool_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/threading/worker_pool_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/timer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete_history_manager_unittest.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/automation/ui_controls_internal_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/automation/url_request_automation_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/background/background_contents_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/background/background_mode_manager_gtk.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/background/background_mode_manager_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browsing_data_quota_helper_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cancelable_request.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/disks/disk_mount_manager.cc View 1 7 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/external_metrics.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_performer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/mock_url_fetchers.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/network_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/tpm_password_fetcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/net/network_change_notifier_chromeos.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/offline/offline_load_page.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/system/statistics_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_prefs.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_cookies_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_devtools_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_idle_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_processes_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_webrequest_api_unittest.cc View 1 4 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/extensions/settings/settings_backend.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/settings/settings_leveldb_storage.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/settings/settings_storage_quota_enforcer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/settings/settings_storage_unittest.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/settings/settings_sync_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/favicon/favicon_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/google/google_update.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/expire_history_backend.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/history.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/history.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/history_extension_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/history_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/shortcuts_backend.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/text_database_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/mac/keystone_glue.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/mock_browsing_data_cookie_helper.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/net/connection_tester.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/cookie_policy_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/crl_set_fetcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/net_pref_observer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/network_stats.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/predictor.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/net/referrer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/sdch_dictionary_fetcher.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/oom_priority_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_mac.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/platform_util_chromeos.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_job_worker.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_system_task_proxy.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/protocol_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/search_host_to_urls_map.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/service/service_process_control.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_components_factory.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/certificate_dialogs.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/fullscreen_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/back_forward_button_gtk.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/gtk/constrained_window_gtk.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_popup_gtk.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_view_gtk.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/tabs/dock_info_gtk.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/accessibility_event_router_views.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/login_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager_backend.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/imageburner/imageburner_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/imageburner/webui_handler.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/screenshot_source.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_internals_ui.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/important_file_writer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/net/gaia/gaia_oauth_client.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/service_process_util_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/worker_thread_ticker.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/net/renderer_net_predictor.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/renderer_histogram_snapshots.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/safe_browsing/malware_dom_details.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_dom_feature_extractor.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_term_feature_extractor.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_helpers.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/cloud_print/print_system_cups.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/service_utility_process_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/webdriver/webdriver_automation.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/webdriver/webdriver_key_converter.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome_frame/chrome_frame_automation.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/chrome_frame_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/custom_sync_call_context.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome_frame/external_tab.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/ready_mode/internal/registry_ready_mode_state.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/task_marshaller.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome_frame/test/html_util_unittests.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/browser_thread_unittest.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M content/browser/device_orientation/provider_unittest.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/download/download_manager_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/download/save_package.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gamepad/gamepad_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gamepad/gamepad_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/geolocation/device_data_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/geolocation/gps_location_provider_linux.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/geolocation/mock_location_provider.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/wifi_data_provider_common.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/geolocation/win7_location_provider_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_data_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/in_process_webkit/dom_storage_area.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/in_process_webkit/indexed_db_context.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/net/url_request_abort_on_end_job.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/plugin_service_impl_browsertest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/async_resource_handler.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/gpu_message_filter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_device_settings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/redirect_to_file_resource_handler.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_browsertest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M content/browser/speech/endpointer/endpointer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/tab_contents/web_drag_source_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/worker_host/message_port_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/gpu/gpu_watchdog_thread.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M content/plugin/webplugin_delegate_stub.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/browser_thread.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/command_buffer_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/command_buffer_proxy.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/gpu_video_decode_accelerator_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/rtc_video_decoder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/notification_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/command_buffer_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M jingle/notifier/base/task_pump.h View 1 chunk +0 lines, -1 line 0 comments Download
M jingle/notifier/listener/mediator_thread_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/audio_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/audio_output_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/audio_output_proxy.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/audio_output_proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/pulse/pulse_output.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/audio_renderer_algorithm_base_unittest.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M media/tools/tile_render_bench/tile_render_bench.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/video/capture/video_capture_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/cookie_monster.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/keygen_handler_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/curvecp/client_packetizer.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/curvecp/messenger.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/curvecp/server_messenger.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/curvecp/test_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_pipelined_connection_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/proxy/proxy_config_service_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/proxy/proxy_config_service_linux_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/proxy/proxy_script_fetcher_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/client_socket_pool_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/web_socket_server_socket_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/socket_stream/socket_stream.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/url_request_ftp_job.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_file_system_proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/ppb_var_deprecated_proxy.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_var_deprecated_proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/shared_impl/callback_tracker.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/shared_impl/tracked_callback.h View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/rectangle_update_decoder.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/host/screen_recorder.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/jingle_glue/jingle_info_request.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/client_control_dispatcher.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/protocol/connection_to_client_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/connection_to_host.h View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/host_event_dispatcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/jingle_session.h View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/jingle_session_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/jingle_session_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M remoting/protocol/protobuf_video_reader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/protobuf_video_writer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/rtp_video_reader.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/rtp_video_writer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/rtp_video_writer_unittest.cc View 1 2 3 5 chunks +5 lines, -5 lines 0 comments Download
M remoting/protocol/util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/root_window.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/surface/accelerated_surface_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/appcache/appcache_group.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/appcache/appcache_request_handler_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/appcache/appcache_storage_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/appcache/appcache_update_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/blob/blob_url_request_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/database/database_connections_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/fileapi/file_system_dir_url_request_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/fileapi/file_system_quota_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/fileapi/file_system_url_request_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/fileapi/file_writer_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/message_channel.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_2d_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_scrollbar_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/quota_file_io.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/quota_file_io_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/quota/mock_storage_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/quota/quota_temporary_storage_evictor_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/support/test_webmessageportchannel.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/test_shell/notification_presenter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/test_shell/simple_appcache_system.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_devtools_agent.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_devtools_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/test_shell/webwidget_host.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
awong
here ya go. 247 files. :)
8 years, 11 months ago (2012-01-06 19:32:07 UTC) #1
James Hawkins
8 years, 11 months ago (2012-01-06 21:15:33 UTC) #2 
Woohoo! LGTM

http://codereview.chromium.org/9114020/diff/9003/base/bind_helpers.h
File base/bind_helpers.h (right):

http://codereview.chromium.org/9114020/diff/9003/base/bind_helpers.h#newcode142
base/bind_helpers.h:142: //   ScopedClosureRunner - Scoper objec that runs the
wrapped closure when it
s/objec/object/

Powered by Google App Engine
This is Rietveld 408576698