Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3755)

Unified Diff: chrome/browser/extensions/extension_webrequest_api_unittest.cc

Issue 9114020: Remove task.h and finish base::Bind() migration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix typo Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_webrequest_api_unittest.cc
diff --git a/chrome/browser/extensions/extension_webrequest_api_unittest.cc b/chrome/browser/extensions/extension_webrequest_api_unittest.cc
index 2d266b5bd1de495c8c3e7f182db079975681ba7c..0eb1aaf20575d5a261c6eb5a0d04ec2e4d8cf47e 100644
--- a/chrome/browser/extensions/extension_webrequest_api_unittest.cc
+++ b/chrome/browser/extensions/extension_webrequest_api_unittest.cc
@@ -9,6 +9,7 @@
#include "base/callback.h"
#include "base/file_util.h"
#include "base/json/json_value_serializer.h"
+#include "base/memory/weak_ptr.h"
#include "base/path_service.h"
#include "base/stl_util.h"
#include "base/utf_string_conversions.h"
@@ -62,7 +63,7 @@ class TestIPCSender : public IPC::Message::Sender {
// Adds a Task to the queue. We will fire these in order as events are
// dispatched.
- void PushTask(base::Closure task) {
+ void PushTask(const base::Closure& task) {
task_queue_.push(task);
}
@@ -361,9 +362,6 @@ class ExtensionWebRequestHeaderModificationTest :
scoped_refptr<TestURLRequestContext> context_;
};
-static void DoNothing() {
-}
-
TEST_P(ExtensionWebRequestHeaderModificationTest, TestModifications) {
std::string extension1_id("1");
std::string extension2_id("2");
@@ -439,7 +437,7 @@ TEST_P(ExtensionWebRequestHeaderModificationTest, TestModifications) {
}
// Don't do anything for the onSendHeaders message.
- ipc_sender_.PushTask(base::Bind(&DoNothing));
+ ipc_sender_.PushTask(base::Bind(&base::DoNothing));
// Note that we mess up the headers slightly:
// request.Start() will first add additional headers (e.g. the User-Agent)
« no previous file with comments | « chrome/browser/extensions/extension_processes_api.cc ('k') | chrome/browser/extensions/settings/settings_backend.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698