Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: chrome/browser/history/history_unittest.cc

Issue 9114020: Remove task.h and finish base::Bind() migration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix typo Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // History unit tests come in two flavors: 5 // History unit tests come in two flavors:
6 // 6 //
7 // 1. The more complicated style is that the unit test creates a full history 7 // 1. The more complicated style is that the unit test creates a full history
8 // service. This spawns a background thread for the history backend, and 8 // service. This spawns a background thread for the history backend, and
9 // all communication is asynchronous. This is useful for testing more 9 // all communication is asynchronous. This is useful for testing more
10 // complicated things or end-to-end behavior. 10 // complicated things or end-to-end behavior.
(...skipping 16 matching lines...) Expand all
27 #include "base/bind_helpers.h" 27 #include "base/bind_helpers.h"
28 #include "base/callback.h" 28 #include "base/callback.h"
29 #include "base/command_line.h" 29 #include "base/command_line.h"
30 #include "base/file_path.h" 30 #include "base/file_path.h"
31 #include "base/file_util.h" 31 #include "base/file_util.h"
32 #include "base/memory/scoped_vector.h" 32 #include "base/memory/scoped_vector.h"
33 #include "base/message_loop.h" 33 #include "base/message_loop.h"
34 #include "base/path_service.h" 34 #include "base/path_service.h"
35 #include "base/scoped_temp_dir.h" 35 #include "base/scoped_temp_dir.h"
36 #include "base/string_util.h" 36 #include "base/string_util.h"
37 #include "base/task.h"
38 #include "base/utf_string_conversions.h" 37 #include "base/utf_string_conversions.h"
39 #include "chrome/browser/history/history.h" 38 #include "chrome/browser/history/history.h"
40 #include "chrome/browser/history/history_backend.h" 39 #include "chrome/browser/history/history_backend.h"
41 #include "chrome/browser/history/history_database.h" 40 #include "chrome/browser/history/history_database.h"
42 #include "chrome/browser/history/history_notifications.h" 41 #include "chrome/browser/history/history_notifications.h"
43 #include "chrome/browser/history/in_memory_database.h" 42 #include "chrome/browser/history/in_memory_database.h"
44 #include "chrome/browser/history/in_memory_history_backend.h" 43 #include "chrome/browser/history/in_memory_history_backend.h"
45 #include "chrome/browser/history/page_usage_data.h" 44 #include "chrome/browser/history/page_usage_data.h"
46 #include "chrome/common/chrome_paths.h" 45 #include "chrome/common/chrome_paths.h"
47 #include "chrome/common/thumbnail_score.h" 46 #include "chrome/common/thumbnail_score.h"
(...skipping 906 matching lines...) Expand 10 before | Expand all | Expand 10 after
954 history_service_ = history; 953 history_service_ = history;
955 history->ScheduleDBTask(task.get(), &request_consumer); 954 history->ScheduleDBTask(task.get(), &request_consumer);
956 request_consumer.CancelAllRequests(); 955 request_consumer.CancelAllRequests();
957 CleanupHistoryService(); 956 CleanupHistoryService();
958 // WARNING: history has now been deleted. 957 // WARNING: history has now been deleted.
959 history = NULL; 958 history = NULL;
960 ASSERT_FALSE(task->done_invoked); 959 ASSERT_FALSE(task->done_invoked);
961 } 960 }
962 961
963 } // namespace history 962 } // namespace history
OLDNEW
« no previous file with comments | « chrome/browser/history/history_extension_api.cc ('k') | chrome/browser/history/shortcuts_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698