Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 8926004: Revert 114095 - Move the concept of Activation to the Shell. (Closed)

Created:
9 years ago by Ben Goodger (Google)
Modified:
9 years ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, kkania, jam, penghuang+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., robertshield, James Su, dhollowa+watch_chromium.org, tfarina
Visibility:
Public.

Description

Revert 114095 - Move the concept of Activation to the Shell. The Active Window is now stored in a property on the RootWindow. Classes wishing to observe changes to this can implement WindowObserver and attach to the RootWindow to be notified of changes in this property. We provide an ActivationClient interface in Aura for customers to use to set/get the active window, and deactivate a window. This is because setting the active window involves more than just changing the property, there is some additional book-keeping that must be done. The ActivationClient is stored in a property on the RootWindow. We also provide an ActivationDelegate interface in Aura that window owners can use to be notified of changes in activation state, and to specify whether or not a window can be activated. The ActivationDelegate should be stored on the relevant window in a property. I moved a lot of Activation-related functionality out of Aura, including all of the unit tests, now on ActivationController, and the associated WindowDelegate implementations which have now become a single TestActivationDelegate implementation. BUG=none TEST=unit tests Review URL: http://codereview.chromium.org/8894018 TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114101

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+680 lines, -1277 lines) Patch
M chrome/browser/automation/testing_automation_provider_aura.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/platform_util_aura.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/aura/chrome_shell_delegate.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.h View 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 3 chunks +4 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 3 chunks +10 lines, -14 lines 0 comments Download
M ui/aura/aura.gyp View 2 chunks +0 lines, -6 lines 0 comments Download
D ui/aura/client/activation_client.h View 1 chunk +0 lines, -42 lines 0 comments Download
D ui/aura/client/activation_client.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D ui/aura/client/activation_delegate.h View 1 chunk +0 lines, -43 lines 0 comments Download
D ui/aura/client/activation_delegate.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M ui/aura/client/aura_constants.h View 2 chunks +18 lines, -34 lines 0 comments Download
M ui/aura/client/aura_constants.cc View 1 chunk +5 lines, -10 lines 0 comments Download
M ui/aura/client/stacking_client.h View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/aura/root_window.h View 5 chunks +23 lines, -2 lines 0 comments Download
M ui/aura/root_window.cc View 7 chunks +78 lines, -18 lines 0 comments Download
M ui/aura/root_window_observer.h View 1 chunk +3 lines, -2 lines 0 comments Download
D ui/aura/test/test_activation_client.h View 1 chunk +0 lines, -44 lines 0 comments Download
D ui/aura/test/test_activation_client.cc View 1 chunk +0 lines, -59 lines 0 comments Download
M ui/aura/test/test_stacking_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/aura/test/test_stacking_client.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M ui/aura/test/test_window_delegate.h View 2 chunks +30 lines, -0 lines 0 comments Download
M ui/aura/test/test_window_delegate.cc View 2 chunks +38 lines, -0 lines 0 comments Download
MM ui/aura/window.h View 3 chunks +12 lines, -2 lines 0 comments Download
M ui/aura/window.cc View 3 chunks +21 lines, -0 lines 0 comments Download
MM ui/aura/window_delegate.h View 1 chunk +12 lines, -0 lines 0 comments Download
MM ui/aura/window_unittest.cc View 3 chunks +146 lines, -0 lines 0 comments Download
D ui/aura_shell/activation_controller.h View 1 chunk +0 lines, -74 lines 0 comments Download
D ui/aura_shell/activation_controller.cc View 1 chunk +0 lines, -185 lines 0 comments Download
D ui/aura_shell/activation_controller_unittest.cc View 1 chunk +0 lines, -281 lines 0 comments Download
MM ui/aura_shell/aura_shell.gyp View 3 chunks +1 line, -5 lines 0 comments Download
MM ui/aura_shell/default_container_event_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM ui/aura_shell/default_container_layout_manager.cc View 2 chunks +1 line, -2 lines 0 comments Download
MM ui/aura_shell/examples/aura_shell_main.cc View 2 chunks +1 line, -2 lines 0 comments Download
MM ui/aura_shell/modal_container_layout_manager.cc View 4 chunks +5 lines, -3 lines 0 comments Download
MM ui/aura_shell/modal_container_layout_manager_unittest.cc View 6 chunks +11 lines, -12 lines 0 comments Download
MM ui/aura_shell/root_window_event_filter.h View 1 chunk +4 lines, -1 line 0 comments Download
MM ui/aura_shell/root_window_event_filter.cc View 3 chunks +14 lines, -4 lines 0 comments Download
MM ui/aura_shell/root_window_event_filter_unittest.cc View 11 chunks +48 lines, -73 lines 0 comments Download
MM ui/aura_shell/shadow_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM ui/aura_shell/shell.h View 2 chunks +0 lines, -2 lines 0 comments Download
MM ui/aura_shell/shell.cc View 2 chunks +0 lines, -3 lines 0 comments Download
MM ui/aura_shell/stacking_controller.h View 1 chunk +7 lines, -0 lines 0 comments Download
MM ui/aura_shell/stacking_controller.cc View 3 chunks +43 lines, -0 lines 0 comments Download
MM ui/aura_shell/stacking_controller_unittest.cc View 1 chunk +59 lines, -0 lines 0 comments Download
D ui/aura_shell/test/test_activation_delegate.h View 1 chunk +0 lines, -59 lines 0 comments Download
D ui/aura_shell/test/test_activation_delegate.cc View 1 chunk +0 lines, -53 lines 0 comments Download
MM ui/aura_shell/window_util.h View 1 chunk +0 lines, -13 lines 0 comments Download
MM ui/aura_shell/window_util.cc View 2 chunks +1 line, -24 lines 0 comments Download
MM ui/aura_shell/workspace/workspace.cc View 2 chunks +1 line, -2 lines 0 comments Download
MM ui/aura_shell/workspace/workspace_manager_unittest.cc View 3 chunks +1 line, -14 lines 0 comments Download
MM ui/aura_shell/workspace_controller.h View 3 chunks +2 lines, -8 lines 0 comments Download
MM ui/aura_shell/workspace_controller.cc View 4 chunks +5 lines, -16 lines 0 comments Download
MM ui/aura_shell/workspace_controller_unittest.cc View 6 chunks +3 lines, -15 lines 0 comments Download
MM ui/views/test/views_test_base.h View 2 chunks +0 lines, -9 lines 0 comments Download
MM ui/views/test/views_test_base.cc View 2 chunks +0 lines, -2 lines 0 comments Download
MM ui/views/widget/native_widget_aura.h View 5 chunks +5 lines, -9 lines 0 comments Download
MM ui/views/widget/native_widget_aura.cc View 9 chunks +32 lines, -45 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ben Goodger (Google)
9 years ago (2011-12-12 22:32:23 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698