Removing MessageLoop::QuitTask() from chrome/

Removing MessageLoop::QuitTask() from chrome/

base/task.h is going away and being replaced by base/bind.h and base/callback.h.
This CL was automatically generated by sed.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113896

[awong, 2011-12-08 20:01:50]

I think a number of there are missing () after QuitClosure.

Can we get a green compile on one bot first?  Otherwise I'm going to end up
writing a lot of "QuitClosure()?" comments.

http://codereview.chromium.org/8873032/diff/1/chrome/browser/autofill/persona...
File chrome/browser/autofill/personal_data_manager_unittest.cc (right):

http://codereview.chromium.org/8873032/diff/1/chrome/browser/autofill/persona...
chrome/browser/autofill/personal_data_manager_unittest.cc:69:
MessageLoop::current()->PostTask(FROM_HERE, MessageLoop::QuitClosure);
QuitClosure()?

http://codereview.chromium.org/8873032/diff/1/chrome/browser/chromeos/login/m...
File chrome/browser/chromeos/login/mock_authenticator.cc (right):

http://codereview.chromium.org/8873032/diff/1/chrome/browser/chromeos/login/m...
chrome/browser/chromeos/login/mock_authenticator.cc:62: BrowserThread::UI,
FROM_HERE, MessageLoop::QuitClosure);
QuitClosure()?

[tfarina, 2011-12-08 20:18:24]

Sent from my iPhone

On 08/12/2011, at 05:55 PM, dcheng@chromium.org wrote:

> Reviewers: awong,
> 
> Description:
> Removing MessageLoop::QuitTask() from chrome/
> 
> base/task.h is going away and being replaced by base/bind.h and
base/callback.h.
> This CL was automatically generated by sed and will be landed via CQ.  

Do you need to tell in the commit message that you are going to land this CL
through commit queue? I think there was a thread in chomium-dev about this. I
don't think this kind of information belongs to commit message.

Thanks!

> BUG=none
> TEST=none
> 
> 
> Please review this at http://codereview.chromium.org/8873032/
> 
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
> 
> Affected files:
>  M chrome/browser/autocomplete/history_contents_provider_unittest.cc
>  M chrome/browser/autofill/personal_data_manager_unittest.cc
>  M chrome/browser/browser_focus_uitest.cc
>  M chrome/browser/browser_process_impl.cc
>  M chrome/browser/chromeos/login/mock_authenticator.cc
>  M chrome/browser/chromeos/login/online_attempt_unittest.cc
>  M chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc
>  M chrome/browser/debugger/devtools_sanity_unittest.cc
>  M chrome/browser/download/download_browsertest.cc
>  M chrome/browser/download/download_test_observer.cc
>  M chrome/browser/extensions/app_notification_manager_sync_unittest.cc
>  M chrome/browser/extensions/app_notification_manager_unittest.cc
>  chrome/browser/extensions/user_script_master_unittest.cc
>  M chrome/browser/fast_shutdown_uitest.cc
>  M chrome/browser/geolocation/access_token_store_browsertest.cc
>  M chrome/browser/history/history_browsertest.cc
>  M chrome/browser/history/history_querying_unittest.cc
>  M chrome/browser/history/history_unittest.cc
>  M chrome/browser/intents/web_intents_registry_unittest.cc
>  M chrome/browser/net/connection_tester_unittest.cc
>  M chrome/browser/net/gaia/token_service_unittest.cc
>  M chrome/browser/net/predictor_unittest.cc
>  M chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
>  M chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc
>  M chrome/browser/password_manager/password_store_default_unittest.cc
>  M chrome/browser/password_manager/password_store_mac_unittest.cc
>  M chrome/browser/password_manager/password_store_win_unittest.cc
>  M chrome/browser/password_manager/password_store_x_unittest.cc
>  M chrome/browser/plugin_test.cc
>  M chrome/browser/prefs/pref_member_unittest.cc
>  M chrome/browser/printing/print_dialog_cloud_uitest.cc
>  M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
>  M chrome/browser/safe_browsing/malware_details_unittest.cc
>  M chrome/browser/search_engines/search_provider_install_data_unittest.cc
>  M chrome/browser/service/service_process_control_browsertest.cc
>  M chrome/browser/speech/speech_input_bubble_controller_unittest.cc
>  M chrome/browser/spellchecker/spellcheck_message_filter_browsertest.cc
>  M chrome/browser/ssl/ssl_browser_tests.cc
>  M chrome/browser/sync/glue/app_notification_data_type_controller_unittest.cc
>  M chrome/browser/sync/glue/browser_thread_model_worker_unittest.cc
>  M chrome/browser/sync/glue/http_bridge_unittest.cc
>  M
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state_unittest.mm
>  M chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc
>  M chrome/browser/ui/intents/web_intents_model_unittest.cc
>  M chrome/browser/ui/panels/panel_browser_view_browsertest.cc
>  M chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc
>  M chrome/browser/visitedlink/visitedlink_unittest.cc
>  M chrome/browser/webdata/web_data_service_unittest.cc
>  M chrome/common/important_file_writer_unittest.cc
>  M chrome/common/service_process_util_unittest.cc
>  M chrome/common/worker_thread_ticker_unittest.cc
>  M chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc
>  M chrome/service/service_process.cc
>  M chrome/test/base/browser_with_test_window_test.cc
>  M chrome/test/base/testing_profile.cc
>  M chrome/test/base/ui_test_utils.cc
> 
> 

[dcheng, 2011-12-08 21:34:05]

Fixed the escaping and reverted the change for testing_profile.cc, as that might
touch a lot of other things.

[awong, 2011-12-09 21:05:55]

LGTM

[awong, 2011-12-09 21:06:13]

On 2011/12/09 21:05:55, awong wrote:
> LGTM

Though, again, no try bot runs.  Either do that or submit via CQ please. :)