Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: chrome/common/service_process_util_unittest.cc

Issue 8873032: Removing MessageLoop::QuitTask() from chrome/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Revert 3 more problematic files Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/important_file_writer_unittest.cc ('k') | chrome/common/worker_thread_ticker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/service_process_util_unittest.cc
diff --git a/chrome/common/service_process_util_unittest.cc b/chrome/common/service_process_util_unittest.cc
index 28ffb7452b11150dc3a31f2c244bcdbd86c1bc37..84db35be0fdbc9ed03e64a038191b8ad0403aebd 100644
--- a/chrome/common/service_process_util_unittest.cc
+++ b/chrome/common/service_process_util_unittest.cc
@@ -51,7 +51,7 @@ void ShutdownTask(MessageLoop* loop) {
// Quit the main message loop.
ASSERT_FALSE(g_good_shutdown);
g_good_shutdown = true;
- loop->PostTask(FROM_HERE, new MessageLoop::QuitTask());
+ loop->PostTask(FROM_HERE, MessageLoop::QuitClosure());
}
} // namespace
@@ -227,7 +227,7 @@ MULTIPROCESS_TEST_MAIN(ServiceProcessStateTestShutdown) {
base::Bind(&ShutdownTask,
MessageLoop::current())));
message_loop.PostDelayedTask(FROM_HERE,
- new MessageLoop::QuitTask(),
+ MessageLoop::QuitClosure(),
TestTimeouts::action_max_timeout_ms());
EXPECT_FALSE(g_good_shutdown);
message_loop.Run();
@@ -305,7 +305,7 @@ class MockLaunchd : public Launchd {
virtual bool RemoveJob(CFStringRef label, CFErrorRef* error) OVERRIDE {
remove_called_ = true;
- message_loop_->PostTask(FROM_HERE, new MessageLoop::QuitTask);
+ message_loop_->PostTask(FROM_HERE, MessageLoop::QuitClosure());
return true;
}
@@ -314,7 +314,7 @@ class MockLaunchd : public Launchd {
CFStringRef name,
CFStringRef session_type) OVERRIDE {
restart_called_ = true;
- message_loop_->PostTask(FROM_HERE, new MessageLoop::QuitTask);
+ message_loop_->PostTask(FROM_HERE, MessageLoop::QuitClosure());
return true;
}
@@ -382,7 +382,7 @@ class ServiceProcessStateFileManipulationTest : public ::testing::Test {
io_thread_.message_loop_proxy(),
base::Closure()));
loop_.PostDelayedTask(FROM_HERE,
- new MessageLoop::QuitTask,
+ MessageLoop::QuitClosure(),
TestTimeouts::action_max_timeout_ms());
}
« no previous file with comments | « chrome/common/important_file_writer_unittest.cc ('k') | chrome/common/worker_thread_ticker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698