chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc - Issue 8873032: Removing MessageLoop::QuitTask() from chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc

Issue 8873032: Removing MessageLoop::QuitTask() from chrome/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revert 3 more problematic files Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state_unittest.mm ('k') | chrome/browser/ui/intents/web_intents_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc

diff --git a/chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc b/chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc

index 2c4c9d526bcbdb77e9b3b481125e79d62c181607..69781b5a8d010c69ba13d8575196a110bed3b696 100644

--- a/chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc

+++ b/chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc

@@ -60,7 +60,7 @@ class WebIntentPickerMock : public WebIntentPicker {

virtual void WaitFor(int target_num_urls, int target_num_default_icons) {

while (num_urls_ != target_num_urls ||

num_default_icons_ != target_num_default_icons) {

- MessageLoop::current()->PostTask(FROM_HERE, new MessageLoop::QuitTask());

+ MessageLoop::current()->PostTask(FROM_HERE, MessageLoop::QuitClosure());

ui_test_utils::RunAllPendingInMessageLoop();

}