Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: chrome/test/base/ui_test_utils.cc

Issue 8873032: Removing MessageLoop::QuitTask() from chrome/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Revert 3 more problematic files Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/browser_with_test_window_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/ui_test_utils.cc
diff --git a/chrome/test/base/ui_test_utils.cc b/chrome/test/base/ui_test_utils.cc
index 1c186357058b157b4acbc6adfda04e1624119454..2462044c7ba9d2ed2bd5061310e0eee4b1366215 100644
--- a/chrome/test/base/ui_test_utils.cc
+++ b/chrome/test/base/ui_test_utils.cc
@@ -244,10 +244,10 @@ bool ExecuteJavaScriptHelper(RenderViewHost* render_view_host,
}
void RunAllPendingMessageAndSendQuit(content::BrowserThread::ID thread_id) {
- MessageLoop::current()->PostTask(FROM_HERE, new MessageLoop::QuitTask());
+ MessageLoop::current()->PostTask(FROM_HERE, MessageLoop::QuitClosure());
RunMessageLoop();
content::BrowserThread::PostTask(thread_id, FROM_HERE,
- new MessageLoop::QuitTask());
+ MessageLoop::QuitClosure());
}
} // namespace
@@ -277,7 +277,7 @@ void RunMessageLoop() {
}
void RunAllPendingInMessageLoop() {
- MessageLoop::current()->PostTask(FROM_HERE, new MessageLoop::QuitTask());
+ MessageLoop::current()->PostTask(FROM_HERE, MessageLoop::QuitClosure());
ui_test_utils::RunMessageLoop();
}
@@ -691,12 +691,12 @@ void TimedMessageLoopRunner::RunFor(int ms) {
void TimedMessageLoopRunner::Quit() {
quit_loop_invoked_ = true;
- loop_->PostTask(FROM_HERE, new MessageLoop::QuitTask);
+ loop_->PostTask(FROM_HERE, MessageLoop::QuitClosure());
}
void TimedMessageLoopRunner::QuitAfter(int ms) {
quit_loop_invoked_ = true;
- loop_->PostDelayedTask(FROM_HERE, new MessageLoop::QuitTask, ms);
+ loop_->PostDelayedTask(FROM_HERE, MessageLoop::QuitClosure(), ms);
}
namespace {
« no previous file with comments | « chrome/test/base/browser_with_test_window_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698