chrome/browser/password_manager/native_backend_gnome_x_unittest.cc - Issue 8873032: Removing MessageLoop::QuitTask() from chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

Issue 8873032: Removing MessageLoop::QuitTask() from chrome/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revert 3 more problematic files Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

diff --git a/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc b/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

index ec57fcd6152b1f3056267f511ad3b2026cf38c06..6f2f8c1d2654e035ff7f259373cbd3c5b1369142 100644

--- a/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

+++ b/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

@@ -307,7 +307,7 @@ class NativeBackendGnomeTest : public testing::Test {

}

virtual void TearDown() {

- MessageLoop::current()->PostTask(FROM_HERE, new MessageLoop::QuitTask);

+ MessageLoop::current()->PostTask(FROM_HERE, MessageLoop::QuitClosure());

MessageLoop::current()->Run();

db_thread_.Stop();

}

@@ -324,7 +324,7 @@ class NativeBackendGnomeTest : public testing::Test {

}

static void PostQuitTask(MessageLoop* loop) {

- loop->PostTask(FROM_HERE, new MessageLoop::QuitTask);

+ loop->PostTask(FROM_HERE, MessageLoop::QuitClosure());

}

void CheckUint32Attribute(const MockKeyringItem* item,