chrome/common/important_file_writer_unittest.cc - Issue 8873032: Removing MessageLoop::QuitTask() from chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/important_file_writer_unittest.cc

Issue 8873032: Removing MessageLoop::QuitTask() from chrome/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revert 3 more problematic files Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/important_file_writer_unittest.cc

diff --git a/chrome/common/important_file_writer_unittest.cc b/chrome/common/important_file_writer_unittest.cc

index 37012d7ed70f22833a012efb632801dce8e54739..9326cd967a9532a5a2d3204babf2e4b964a8bea2 100644

--- a/chrome/common/important_file_writer_unittest.cc

+++ b/chrome/common/important_file_writer_unittest.cc

@@ -76,7 +76,7 @@ TEST_F(ImportantFileWriterTest, ScheduleWrite) {

writer.ScheduleWrite(&serializer);

EXPECT_TRUE(writer.HasPendingWrite());

MessageLoop::current()->PostDelayedTask(FROM_HERE,

- new MessageLoop::QuitTask(), 100);

+ MessageLoop::QuitClosure(), 100);

MessageLoop::current()->Run();

EXPECT_FALSE(writer.HasPendingWrite());

ASSERT_TRUE(file_util::PathExists(writer.path()));

@@ -92,7 +92,7 @@ TEST_F(ImportantFileWriterTest, DoScheduledWrite) {

EXPECT_TRUE(writer.HasPendingWrite());

writer.DoScheduledWrite();

MessageLoop::current()->PostDelayedTask(FROM_HERE,

- new MessageLoop::QuitTask(), 100);

+ MessageLoop::QuitClosure(), 100);

MessageLoop::current()->Run();

EXPECT_FALSE(writer.HasPendingWrite());

ASSERT_TRUE(file_util::PathExists(writer.path()));

@@ -108,7 +108,7 @@ TEST_F(ImportantFileWriterTest, BatchingWrites) {

writer.ScheduleWrite(&bar);

writer.ScheduleWrite(&baz);

MessageLoop::current()->PostDelayedTask(FROM_HERE,

- new MessageLoop::QuitTask(), 100);

+ MessageLoop::QuitClosure(), 100);

MessageLoop::current()->Run();

ASSERT_TRUE(file_util::PathExists(writer.path()));

EXPECT_EQ("baz", GetFileContent(writer.path()));