Make Aura and compositor stacking methods more intuitive.

Make Aura and compositor stacking methods more intuitive.

aura::Window::StackChildAbove() and ui::Layer::StackAbove()
stacked entity A directly above entity B... unless A was
already somewhere above B in the stack, in which case they'd
do nothing.  I see the caveat as making these methods less
useful, and I'm unable to think of any benefits from it, so
this change makes the methods place A directly above B in
all cases (possibly lowering A in the stacking order if it
was previously far above B).

This also fixes an issue in the Aura shell's shadow-stacking
code where ShadowController could inadvertently raise a
window to the top of the stacking order.

BUG=101977
TEST=added

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111264

[sky, 2011-11-22 22:44:54]

LGTM

http://codereview.chromium.org/8653005/diff/1/ui/aura_shell/shadow_controller...
File ui/aura_shell/shadow_controller_unittest.cc (right):

http://codereview.chromium.org/8653005/diff/1/ui/aura_shell/shadow_controller...
ui/aura_shell/shadow_controller_unittest.cc:14: #include
"ui/aura_shell/shadow_controller.h"
nit: test files should have headers organized like .cc files, so that this
include should be first.

[sky, 2011-11-22 22:46:08]

I'm tempted to suggest moving the duplicated logic into a template function that
both places use.

[Daniel Erat, 2011-11-22 22:58:42]

(as discussed in person, i was thinking of abstracting out the reordering code
too but couldn't come up with a good spot for it)

http://codereview.chromium.org/8653005/diff/1/ui/aura_shell/shadow_controller...
File ui/aura_shell/shadow_controller_unittest.cc (right):

http://codereview.chromium.org/8653005/diff/1/ui/aura_shell/shadow_controller...
ui/aura_shell/shadow_controller_unittest.cc:14: #include
"ui/aura_shell/shadow_controller.h"
On 2011/11/22 22:44:54, sky wrote:
> nit: test files should have headers organized like .cc files, so that this
> include should be first.

Done.