Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 8609010: Make DevToolsManager a singleton, remove it from ContentBrowserClient (Closed)

Created:
9 years, 1 month ago by yurys
Modified:
9 years, 1 month ago
Reviewers:
jam, pfeldman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke-watch+content_chromium.org, jam, Paweł Hajdan Jr.
Visibility:
Public.

Description

Make DevToolsManager a singleton, remove it from ContentBrowserClient. DevToolsManager should be created and destroyed inside content implementation, not by the embedder. BUG=104625 TEST=Exising tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111106

Patch Set 1 #

Patch Set 2 : Reverted notification service changes, use non-leaky singleton #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -63 lines) Patch
M chrome/browser/browser_process.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 4 chunks +0 lines, -15 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_browser_process.h View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/test/base/testing_browser_process.cc View 4 chunks +1 line, -11 lines 0 comments Download
M content/browser/debugger/devtools_manager.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/debugger/devtools_manager.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/debugger/devtools_manager_unittest.cc View 3 chunks +1 line, -7 lines 0 comments Download
M content/browser/mock_content_browser_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/mock_content_browser_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/browser/content_browser_client.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/shell/shell_content_browser_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/shell_content_browser_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
Since DevToolsManager now listens to NOTIFICATION_MAIN_LOOP_EXITING to delete itself, it will leak in devtools_manager_unittest.cc I ...
9 years, 1 month ago (2011-11-21 09:41:46 UTC) #1
yurys
As suggested in http://codereview.chromium.org/8549022/diff/4001/content/browser/browser_main_loop.cc#newcode301 I made DevToolsManager a non-leaky singleton(option 1 described above) and reverted ...
9 years, 1 month ago (2011-11-21 15:57:55 UTC) #2
pfeldman
lgtm
9 years, 1 month ago (2011-11-21 16:01:57 UTC) #3
jam
9 years, 1 month ago (2011-11-21 18:30:58 UTC) #4
lgtm, thanks

Powered by Google App Engine
This is Rietveld 408576698