chrome/browser/ui/browser.cc - Issue 8609010: Make DevToolsManager a singleton, remove it from ContentBrowserClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 8609010: Make DevToolsManager a singleton, remove it from ContentBrowserClient (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Reverted notification service changes, use non-leaky singleton Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index 3f65a096c3a2f3558b083b1138d56e7ddac98cbc..6277ae8ec7ac8f90197adb3d81b8916cfd7a4a4f 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -4103,7 +4103,7 @@ void Browser::Observe(int type,

} else if (pref_name == prefs::kDevToolsDisabled) {

UpdateCommandsForDevTools();

if (profile_->GetPrefs()->GetBoolean(prefs::kDevToolsDisabled))

- g_browser_process->devtools_manager()->CloseAllClientHosts();

+ DevToolsManager::GetInstance()->CloseAllClientHosts();

} else if (pref_name == prefs::kEditBookmarksEnabled) {

UpdateCommandsForBookmarkEditing();

} else if (pref_name == prefs::kShowBookmarkBar) {