Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: content/browser/debugger/devtools_manager_unittest.cc

Issue 8609010: Make DevToolsManager a singleton, remove it from ContentBrowserClient (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reverted notification service changes, use non-leaky singleton Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/debugger/devtools_manager.cc ('k') | content/browser/mock_content_browser_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/debugger/devtools_manager_unittest.cc
diff --git a/content/browser/debugger/devtools_manager_unittest.cc b/content/browser/debugger/devtools_manager_unittest.cc
index a2b3bf0f556c7d674d761d52193b93ce9f481d96..f7daf85e9aee2737e3f1bb077b459ad59cdd3d91 100644
--- a/content/browser/debugger/devtools_manager_unittest.cc
+++ b/content/browser/debugger/devtools_manager_unittest.cc
@@ -92,10 +92,6 @@ class DevToolsManagerTestBrowserClient
DevToolsManagerTestBrowserClient() {
}
- virtual DevToolsManager* GetDevToolsManager() OVERRIDE {
- return &dev_tools_manager_;
- }
-
virtual bool ShouldSwapProcessesForNavigation(
const GURL& current_url,
const GURL& new_url) OVERRIDE {
@@ -103,8 +99,6 @@ class DevToolsManagerTestBrowserClient
}
private:
- DevToolsManager dev_tools_manager_;
-
DISALLOW_COPY_AND_ASSIGN(DevToolsManagerTestBrowserClient);
};
@@ -182,7 +176,7 @@ TEST_F(DevToolsManagerTest, NoUnresponsiveDialogInInspectedTab) {
contents()->set_delegate(&delegate);
TestDevToolsClientHost client_host;
- content::GetContentClient()->browser()->GetDevToolsManager()->
+ DevToolsManager::GetInstance()->
RegisterDevToolsClientHostFor(inspected_rvh, &client_host);
// Start with a short timeout.
« no previous file with comments | « content/browser/debugger/devtools_manager.cc ('k') | content/browser/mock_content_browser_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698