content/browser/debugger/devtools_manager.h - Issue 8609010: Make DevToolsManager a singleton, remove it from ContentBrowserClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/debugger/devtools_manager.h

Issue 8609010: Make DevToolsManager a singleton, remove it from ContentBrowserClient (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Reverted notification service changes, use non-leaky singleton Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/debugger/devtools_manager.h

diff --git a/content/browser/debugger/devtools_manager.h b/content/browser/debugger/devtools_manager.h

index 1801d0c1eb5638bd7772d52b6a4a1a33ec1caf3f..f589c850fe40f5b1836fe49608e7b8fe0f17a984 100644

--- a/content/browser/debugger/devtools_manager.h

+++ b/content/browser/debugger/devtools_manager.h

@@ -10,6 +10,7 @@

#include <string>

#include "base/compiler_specific.h"

+#include "base/memory/singleton.h"

#include "content/browser/debugger/devtools_agent_host.h"

#include "content/browser/debugger/devtools_client_host.h"

#include "content/common/content_export.h"

@@ -88,6 +89,8 @@ class CONTENT_EXPORT DevToolsManager

int DetachClientHost(DevToolsAgentHost* from_agent);

private:

+ friend struct DefaultSingletonTraits<DevToolsManager>;

// DevToolsClientHost::CloseListener override.

// This method will remove all references from the manager to the

// DevToolsClientHost and unregister all listeners related to the