Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: chrome/browser/ui/browser.cc

Issue 8609010: Make DevToolsManager a singleton, remove it from ContentBrowserClient (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reverted notification service changes, use non-leaky singleton Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser.h" 5 #include "chrome/browser/ui/browser.h"
6 6
7 #if defined(OS_WIN) 7 #if defined(OS_WIN)
8 #include <windows.h> 8 #include <windows.h>
9 #include <shellapi.h> 9 #include <shellapi.h>
10 #endif // OS_WIN 10 #endif // OS_WIN
(...skipping 4085 matching lines...) Expand 10 before | Expand all | Expand 10 after
4096 instant_unload_handler_.reset(); 4096 instant_unload_handler_.reset();
4097 } 4097 }
4098 } else { 4098 } else {
4099 CreateInstantIfNecessary(); 4099 CreateInstantIfNecessary();
4100 } 4100 }
4101 } else if (pref_name == prefs::kIncognitoModeAvailability) { 4101 } else if (pref_name == prefs::kIncognitoModeAvailability) {
4102 UpdateCommandsForIncognitoAvailability(); 4102 UpdateCommandsForIncognitoAvailability();
4103 } else if (pref_name == prefs::kDevToolsDisabled) { 4103 } else if (pref_name == prefs::kDevToolsDisabled) {
4104 UpdateCommandsForDevTools(); 4104 UpdateCommandsForDevTools();
4105 if (profile_->GetPrefs()->GetBoolean(prefs::kDevToolsDisabled)) 4105 if (profile_->GetPrefs()->GetBoolean(prefs::kDevToolsDisabled))
4106 g_browser_process->devtools_manager()->CloseAllClientHosts(); 4106 DevToolsManager::GetInstance()->CloseAllClientHosts();
4107 } else if (pref_name == prefs::kEditBookmarksEnabled) { 4107 } else if (pref_name == prefs::kEditBookmarksEnabled) {
4108 UpdateCommandsForBookmarkEditing(); 4108 UpdateCommandsForBookmarkEditing();
4109 } else if (pref_name == prefs::kShowBookmarkBar) { 4109 } else if (pref_name == prefs::kShowBookmarkBar) {
4110 UpdateCommandsForBookmarkBar(); 4110 UpdateCommandsForBookmarkBar();
4111 UpdateBookmarkBarState(BOOKMARK_BAR_STATE_CHANGE_PREF_CHANGE); 4111 UpdateBookmarkBarState(BOOKMARK_BAR_STATE_CHANGE_PREF_CHANGE);
4112 } else if (pref_name == prefs::kHomePage) { 4112 } else if (pref_name == prefs::kHomePage) {
4113 PrefService* pref_service = content::Source<PrefService>(source).ptr(); 4113 PrefService* pref_service = content::Source<PrefService>(source).ptr();
4114 MarkHomePageAsChanged(pref_service); 4114 MarkHomePageAsChanged(pref_service);
4115 } else if (pref_name == prefs::kAllowFileSelectionDialogs) { 4115 } else if (pref_name == prefs::kAllowFileSelectionDialogs) {
4116 UpdateSaveAsState(GetContentRestrictionsForSelectedTab()); 4116 UpdateSaveAsState(GetContentRestrictionsForSelectedTab());
(...skipping 1155 matching lines...) Expand 10 before | Expand all | Expand 10 after
5272 window_->GetLocationBar()->ShowFirstRunBubble(bubble_type); 5272 window_->GetLocationBar()->ShowFirstRunBubble(bubble_type);
5273 } else if (is_type_tabbed()) { 5273 } else if (is_type_tabbed()) {
5274 GlobalErrorService* service = 5274 GlobalErrorService* service =
5275 GlobalErrorServiceFactory::GetForProfile(profile()); 5275 GlobalErrorServiceFactory::GetForProfile(profile());
5276 GlobalError* error = service->GetFirstGlobalErrorWithBubbleView(); 5276 GlobalError* error = service->GetFirstGlobalErrorWithBubbleView();
5277 if (error) { 5277 if (error) {
5278 error->ShowBubbleView(this); 5278 error->ShowBubbleView(this);
5279 } 5279 }
5280 } 5280 }
5281 } 5281 }
OLDNEW
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/test/base/testing_browser_process.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698